From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B527FC433F5 for ; Mon, 11 Apr 2022 08:37:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343900AbiDKIkC (ORCPT ); Mon, 11 Apr 2022 04:40:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233263AbiDKIjy (ORCPT ); Mon, 11 Apr 2022 04:39:54 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7D45D3EA89 for ; Mon, 11 Apr 2022 01:37:41 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 49159ED1; Mon, 11 Apr 2022 01:37:41 -0700 (PDT) Received: from bogus (unknown [10.57.41.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 293683F73B; Mon, 11 Apr 2022 01:37:39 -0700 (PDT) Date: Mon, 11 Apr 2022 09:37:36 +0100 From: Sudeep Holla To: Qing Wang , Greg Kroah-Hartman Cc: "Rafael J. Wysocki" , Sudeep Holla , linux-kernel@vger.kernel.org Subject: Re: [PATCH] arch_topology: Do not set llc_sibling if llc_id is invalid Message-ID: <20220411083736.hrpgndcwuvtsgnhc@bogus> References: <1649644580-54626-1-git-send-email-wangqing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1649644580-54626-1-git-send-email-wangqing@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Qing, On Sun, Apr 10, 2022 at 07:36:19PM -0700, Qing Wang wrote: > From: Wang Qing > > When ACPI is not enabled, cpuid_topo->llc_id = cpu_topo->llc_id = -1, which > will set llc_sibling 0xff(...), this is misleading. > > Don't set llc_sibling(default 0) if we don't know the cache topology. > Makes sense to me and thanks for splitting the patch and pointing this out clearly. Your earlier patches mixed other things and made it hard to highlight this one. Reviewed-by: Sudeep Holla Hi Greg, Can you pick this up ? IMO It can go as fix in -rc as it is kind of misleading though I am not sure if it is breaking any platform. -- Regards, Sudeep