From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F957C433EF for ; Tue, 12 Apr 2022 18:06:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358600AbiDLSI7 (ORCPT ); Tue, 12 Apr 2022 14:08:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239431AbiDLSI4 (ORCPT ); Tue, 12 Apr 2022 14:08:56 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E85E4CD5C for ; Tue, 12 Apr 2022 11:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649786798; x=1681322798; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IeaSKSuXPhVpXFM/OGOekdHqEQjfF86SwDcNvu0ysGk=; b=nggviThdHYwy2EYrznEuH+LirmSCGdvzQWuh9LdWXX2dDajsy+lUNYgS kMErNyHoIR90U0JLjDvRdHVl5G3CzUxx6Y5u6/51M7aY89H8YebASj/+6 yYW+pMgyy2N0je3SZkWwG8mLzBwIw2/8XMVUpvYostnb2xM34WYyvddVK D98cpNkUWaz4Jfc1UJb4As1/T5iBSi4ATs8c1brkvwAKex20liBxqvuIt Tnn2lPXjKmhf4BvfwZeZHT7yMHsC37kcuync3BvPHqWi+4O6kE7howvqY 3Nc7FEvGYuVHkIcVEUu2h8FQp3VIFMb40OQMdwPNKeM1gbNKsQT/lydLf g==; X-IronPort-AV: E=McAfee;i="6400,9594,10315"; a="244347985" X-IronPort-AV: E=Sophos;i="5.90,254,1643702400"; d="scan'208";a="244347985" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2022 10:57:25 -0700 X-IronPort-AV: E=Sophos;i="5.90,254,1643702400"; d="scan'208";a="724563522" Received: from alison-desk.jf.intel.com (HELO alison-desk) ([10.54.74.41]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2022 10:57:23 -0700 Date: Tue, 12 Apr 2022 10:59:17 -0700 From: Alison Schofield To: Bruno Moreira-Guedes Cc: Greg Kroah-Hartman , Martyn Welch , Manohar Vanga , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Bruno's Patch Watchbox Subject: Re: [PATCH v2 1/3] staging: vme: Adjusted VME_USER in Kconfig Message-ID: <20220412175917.GA1236898@alison-desk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 12, 2022 at 03:55:21AM -0300, Bruno Moreira-Guedes wrote: 'Adjusted' is unecessarily vague. In the commit msg try to say exactly what the patch did. Write in the imperative tense, like you are issuing commands. Something like 'Move VME staging driver to staging Kconfig' , or 'Source vme driver from staging Kconfig'. > Currently, the VME_USER driver is in the staging tree Kconfig, unlike > other VME drivers already moved to the main portions of the kernel tree. > Its configuration is, however, nested into the VME_BUS config option, > which might be misleading. > > Since the staging tree "[...] is used to hold stand-alone[1] drivers and > filesystem that are not ready to be merged into the main portion of the > Linux kernel tree [...]"[1], IMHO all staging drivers should appear Skip the 'IMHO'. It's all your HO and if you state anything incorrectly, your reviewers should catch it. If you are truly making a wild guess about something, either look into it further, or not it in a question below the '---'. This commit message is otherwise very well written. It explains the why of this patch nicely. Again, for this set, perhaps the changelog in the cover letter only. > nested into the Main Menu -> Device Drivers -> Staging Drivers to make > sure the user don't pick it without being fully aware of its staging > status as it could be the case in Menu -> Device Drivers -> VME bridge > support (the current location). > > With this change menuconfig users will clearly know this is not a driver > in the main portion of the kernel tree and decide whether to build it or > not with that clearly in mind. > > This change goes into the same direction of commit 4b4cdf3979c3 > ("STAGING: Move staging drivers back to staging-specific menu") > > CHANGELOG > v1: > - Sourced "drivers/staging/vme/devices/Kconfig" in > "drivers/staging/Kconfig" and unsourced in "drivers/vme/Kconfig". > > v2: > - Turned into a patchset to (1) fix missing "depends on" missing entry > in config VME_USER at "drivers/staging/vme/devices/Kconfig", > affecting the behavior of this patch, and (2) fix unnecessary > remaining files from the time the whole vme subtree was in staging. > > REFERENCES > [1] https://lkml.org/lkml/2009/3/18/314 > > Signed-off-by: Bruno Moreira-Guedes > --- > drivers/staging/Kconfig | 2 ++ > drivers/vme/Kconfig | 2 -- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig > index 932acb4e8cbc..0545850eb2ff 100644 > --- a/drivers/staging/Kconfig > +++ b/drivers/staging/Kconfig > @@ -88,4 +88,6 @@ source "drivers/staging/qlge/Kconfig" > > source "drivers/staging/wfx/Kconfig" > > +source "drivers/staging/vme/devices/Kconfig" > + > endif # STAGING > diff --git a/drivers/vme/Kconfig b/drivers/vme/Kconfig > index 936392ca3c8c..c13dd9d2a604 100644 > --- a/drivers/vme/Kconfig > +++ b/drivers/vme/Kconfig > @@ -15,6 +15,4 @@ source "drivers/vme/bridges/Kconfig" > > source "drivers/vme/boards/Kconfig" > > -source "drivers/staging/vme/devices/Kconfig" > - > endif # VME > -- > 2.35.1 >