From: Xiaomeng Tong <xiam0nd.tong@gmail.com>
To: patrik.r.jakobsson@gmail.com
Cc: airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
xiam0nd.tong@gmail.com
Subject: Re: [PATCH v2] drm/gma500: fix a potential repeat execution in psb_driver_load
Date: Wed, 13 Apr 2022 13:17:34 +0800 [thread overview]
Message-ID: <20220413051734.5975-1-xiam0nd.tong@gmail.com> (raw)
In-Reply-To: <CAMeQTsaXM-ddGLukxuEJvm+0UtuJEZGL_5KEY8h9ZPH-ZxmBsQ@mail.gmail.com>
On Tue, 12 Apr 2022 16:58:24 +0200, Patrik Jakobsson wrote:
> Hi,
> This would work but using gotos like this easily turns the code into
> spaghetti. See "7. Centralized exiting of functions" in
> Documentation/process/coding-style.rst for when to use gotos.
>
> In this particular case I think we are better off using an
> if-statement. What about something like this:
>
> if (gma_encoder->type == INTEL_OUTPUT_LVDS ||
> gma_encoder->type == INTEL_OUTPUT_MIPI) {
> ret = gma_backlight_init();
> break;
> }
Yes, it looks better.
I have sent a PATCH v3 with changes as you suggested, please check it.
Thank you very much.
--
Xiaomeng Tong
prev parent reply other threads:[~2022-04-13 5:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 11:31 Xiaomeng Tong
2022-04-12 14:58 ` Patrik Jakobsson
2022-04-13 5:17 ` Xiaomeng Tong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220413051734.5975-1-xiam0nd.tong@gmail.com \
--to=xiam0nd.tong@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®