From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06094C433EF for ; Wed, 13 Apr 2022 11:58:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235303AbiDMMBG (ORCPT ); Wed, 13 Apr 2022 08:01:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230513AbiDMMAn (ORCPT ); Wed, 13 Apr 2022 08:00:43 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A83715D672 for ; Wed, 13 Apr 2022 04:58:14 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id r13so3447642ejd.5 for ; Wed, 13 Apr 2022 04:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=t+e8bSlO8HlFBx5QkC+YWhBBQ1KUbhRpOI9qNhDs95Q=; b=i3WWwCf7E9CLGuSIAfuJvq73Vxp3xh8JfHrEwq8LVCHc/Lqg0XG/6gf/RJ29vCQnMH NMbMNVFLkjmF88dC0oiBDKaY/HZRFuqP3yJe4UwvgvMDUjWYjHdX/wjwU7xAuii3U0uH H+I6DYLijb6SNsb01RPyEa5xpnfOtYw8FFUeo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=t+e8bSlO8HlFBx5QkC+YWhBBQ1KUbhRpOI9qNhDs95Q=; b=Z9uuahBo4cbycDPvAPo8eQNAjIoUC0IvjHPlnwPzoP+TJvHmxNpT7VOaYgEpf7RXgA MWpTuHpCFEqXuNATi59ffdmUiTYhqYgyBrddFaqsyeB450hQtkNvLeWbCspldEo28FeX RwpHVwlkURWePAgMxExhl6OkceolzfKvEL36tfBapGqQLJkDO1t6tJN1/1lEFZ6l1NO+ ImHU8BGkjvMvydE2x7Ki2SgQujsWlfZKuW4lBh55233sohMkyhIfG3iJLAXvizPzPdJ8 /xfpoQF/ScLl8TypW2Pfpq0M7haThtzE/CuN2gJXbAM11xVrWB9MwVttqR2zgYej68pC 2x4w== X-Gm-Message-State: AOAM533Vfn/eFKbudJQu/5+L4p+j0YwcF08ZZwWcJ2uqA+49Er4VEab+ p8obHF39KydenCmtYRqN0Uk14w== X-Google-Smtp-Source: ABdhPJwXevi2Yb3Y0tNYmPOsqfGxi/mGuGC3rrIyPQKgl7WIkrLCz3vEz1hoO92Z5sYeOExAS0ZJEw== X-Received: by 2002:a17:906:d54e:b0:6db:b241:c0e2 with SMTP id cr14-20020a170906d54e00b006dbb241c0e2mr37937273ejc.724.1649851093155; Wed, 13 Apr 2022 04:58:13 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i (host-95-245-147-71.retail.telecomitalia.it. [95.245.147.71]) by smtp.gmail.com with ESMTPSA id s4-20020a170906bc4400b006e893908c4csm3262077ejv.60.2022.04.13.04.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 04:58:12 -0700 (PDT) Date: Wed, 13 Apr 2022 13:58:10 +0200 From: Tommaso Merciai To: Krzysztof Kozlowski Cc: linux-amarula@amarulasolutions.com, Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Joakim Zhang , Tim Harvey , Richard Zhu , Li Jun , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: imx8mm-evk: add pwm1/backlight support Message-ID: <20220413115810.GA4713@tom-ThinkPad-T14s-Gen-2i> References: <20220413102052.20207-1-tommaso.merciai@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 13, 2022 at 12:28:00PM +0200, Krzysztof Kozlowski wrote: > On 13/04/2022 12:20, Tommaso Merciai wrote: > > Add pwm1/backlight support nodes for imx8mm_evk board. Align with u-boot > > dts > > > > References: > > - https://patchwork.ozlabs.org/project/uboot/patch/20220326111911.13720-9-tommaso.merciai@amarulasolutions.com/ > > > > Signed-off-by: Tommaso Merciai > > --- > > arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 21 +++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > index 6d67df7692f1..55566708f667 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > @@ -59,6 +59,15 @@ reg_usdhc2_vmmc: regulator-usdhc2 { > > enable-active-high; > > }; > > > > + backlight: backlight { > > + status = "disabled"; > > Why disabled? > > > + compatible = "pwm-backlight"; > > + pwms = <&pwm1 0 5000000>; > > + brightness-levels = <0 255>; > > + num-interpolated-steps = <255>; > > + default-brightness-level = <250>; > > + }; > > + > > ir-receiver { > > compatible = "gpio-ir-receiver"; > > gpios = <&gpio1 13 GPIO_ACTIVE_LOW>; > > @@ -395,6 +404,12 @@ &wdog1 { > > status = "okay"; > > }; > > > > +&pwm1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_backlight>; > > + status = "disabled"; > > Same here. > > > Best regards, > Krzysztof Hi Krzysztof, I think is better to keep disable into .dtsi and enable it at .dts level. What do you think about? Regards, Tommaso -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com