From: Marcel Ziswiler <marcel@ziswiler.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Max Krummenacher <max.krummenacher@toradex.com>,
Denys Drozdov <denys.drozdov@toradex.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Fabio Estevam <festevam@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>, Stefan Agner <stefan@agner.ch>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 02/14] ARM: dts: imx6ull-colibri: fix vqmmc regulator
Date: Thu, 14 Apr 2022 10:50:54 +0200 [thread overview]
Message-ID: <20220414085106.18621-3-marcel@ziswiler.com> (raw)
In-Reply-To: <20220414085106.18621-1-marcel@ziswiler.com>
From: Max Krummenacher <max.krummenacher@toradex.com>
The correct spelling for the property is gpios. Otherwise, the regulator
will neither reserve nor control any GPIOs. Thus, any SD/MMC card which
can use UHS-I modes will fail.
Fixes: c2e4987e ("ARM: dts: imx6ull: add Toradex Colibri iMX6ULL support")
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
Signed-off-by: Denys Drozdov <denys.drozdov@toradex.com>
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---
arch/arm/boot/dts/imx6ull-colibri.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6ull-colibri.dtsi b/arch/arm/boot/dts/imx6ull-colibri.dtsi
index 84bb7574d211..eb13ed60d2e4 100644
--- a/arch/arm/boot/dts/imx6ull-colibri.dtsi
+++ b/arch/arm/boot/dts/imx6ull-colibri.dtsi
@@ -37,7 +37,7 @@ reg_module_3v3_avdd: regulator-module-3v3-avdd {
reg_sd1_vmmc: regulator-sd1-vmmc {
compatible = "regulator-gpio";
- gpio = <&gpio5 9 GPIO_ACTIVE_HIGH>;
+ gpios = <&gpio5 9 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_snvs_reg_sd>;
regulator-always-on;
--
2.35.1
next prev parent reply other threads:[~2022-04-14 8:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 8:50 [PATCH v1 00/14] ARM: dts: imx6ull-colibri: device tree improvements Marcel Ziswiler
2022-04-14 8:50 ` [PATCH v1 01/14] ARM: dts: imx6ull-colibri: use pull-down for adc pins Marcel Ziswiler
2022-04-14 8:50 ` Marcel Ziswiler [this message]
2022-04-24 13:02 ` [PATCH v1 02/14] ARM: dts: imx6ull-colibri: fix vqmmc regulator Shawn Guo
2022-04-14 8:50 ` [PATCH v1 03/14] ARM: dts: imx6ull-colibri: change touch i2c parameters Marcel Ziswiler
2022-04-14 8:50 ` [PATCH v1 04/14] ARM: dts: imx6ull-colibri: add phy-supply to fec Marcel Ziswiler
2022-04-14 8:50 ` [PATCH v1 05/14] ARM: dts: imx6ull-colibri: add touchscreen device nodes Marcel Ziswiler
2022-04-24 13:05 ` Shawn Guo
2022-04-14 8:50 ` [PATCH v1 06/14] ARM: dts: imx6ull-colibri: update usdhc1 pixmux and signaling Marcel Ziswiler
2022-04-14 8:50 ` [PATCH v1 07/14] ARM: dts: imx6ull-colibri: update device trees to support overlays Marcel Ziswiler
2022-04-14 8:51 ` [PATCH v1 08/14] ARM: dts: imx6ull-colibri: add gpio-line-names Marcel Ziswiler
2022-04-14 8:51 ` [PATCH v1 09/14] dt-bindings: arm: fsl: add toradex,colibri-imx6ull Marcel Ziswiler
2022-04-14 12:20 ` Rob Herring
2022-04-14 8:51 ` [PATCH v1 10/14] ARM: dts: imx6ull-colibri: add support for toradex iris carrier boards Marcel Ziswiler
2022-04-14 8:51 ` [PATCH v1 11/14] ARM: dts: imx6ull-colibri: add support for toradex aster " Marcel Ziswiler
2022-04-14 8:51 ` [PATCH v1 12/14] ARM: dts: imx6ull-colibri: fix nand bch geometry Marcel Ziswiler
2022-04-14 8:51 ` [PATCH v1 13/14] ARM: dts: imx6ull-colibri: add/update some comments Marcel Ziswiler
2022-04-14 8:51 ` [PATCH v1 14/14] ARM: dts: imx6ull-colibri: move gpio-keys node to som dtsi Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220414085106.18621-3-marcel@ziswiler.com \
--to=marcel@ziswiler.com \
--cc=denys.drozdov@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frowand.list@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marcel.ziswiler@toradex.com \
--cc=max.krummenacher@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®