From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF250C433F5 for ; Thu, 14 Apr 2022 09:34:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233438AbiDNJhW (ORCPT ); Thu, 14 Apr 2022 05:37:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241295AbiDNJhQ (ORCPT ); Thu, 14 Apr 2022 05:37:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B4C01A809; Thu, 14 Apr 2022 02:34:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 12E2561B95; Thu, 14 Apr 2022 09:34:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9B06C385A1; Thu, 14 Apr 2022 09:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649928891; bh=V0Du7oRyUyAoNsyD73VGs8c8uXavo0mgfxNJb0Ar+HQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g/BgrtHbJLQ4/pNzKYsvUe/UEZjUk04bl9vUd9zMgYHSfrw9yaSnDeEusmSIUkoPK 6L2ANTrQUrByTUgOTRgSaFJfUJWWyQwoMunt05vx60Ud+8KjMh9QASr3zG/YNgr3Bt wtpKE3Qj43dAKUXUJxZ+NtU66H+6S+M3T5lw4HI+hgdPdFhFcIfL8u7HBYkKJ4G4iH q3kVeAgAZlcRuS7qsv7iI9eBp88cTSXb1gA7+Az5bfxMK8nYPOODF3a6Ih+rL818HW rbFF72ribsA2OIDOTTZmLR2teKzdYiNNE24KIyzzzE09lJTMyDKrY9K9BGQAb4t+O5 ax36KmEmQPFag== Date: Thu, 14 Apr 2022 10:34:45 +0100 From: Will Deacon To: "Jason A. Donenfeld" Cc: Tianjia Zhang , Herbert Xu , "David S. Miller" , Catalin Marinas , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: arm64/sm4 - Fix wrong dependency of NEON/CE implementation Message-ID: <20220414093445.GA2006@willie-the-truck> References: <20220411031313.35449-1-tianjia.zhang@linux.alibaba.com> <20220413102209.GB1229@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 13, 2022 at 01:48:53PM +0200, Jason A. Donenfeld wrote: > On Wed, Apr 13, 2022 at 11:22:09AM +0100, Will Deacon wrote: > > On Mon, Apr 11, 2022 at 11:13:13AM +0800, Tianjia Zhang wrote: > > > Commit d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") > > > moved the sm4 library implementation from the lib/crypto directory to > > > the crypto directory and configured the name as CRYPTO_SM4. The arm64 > > > SM4 NEON/CE implementation depends on this and needs to be modified > > > uniformly. > > > > d2825fa9365d doesn't appear in my tree -- is this something in linux-next? > > This is in Herbert's tree for next: > https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=d2825fa9365d Cheers, then I'll leave this fix for Herbert to pick up. Will