From: Guenter Roeck <linux@roeck-us.net>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
kernel test robot <lkp@intel.com>, Arnd Bergmann <arnd@arndb.de>,
Takashi Iwai <tiwai@suse.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v3] sound/oss/dmasound: fix build when drivers are mixed =y/=m
Date: Fri, 15 Apr 2022 06:48:52 -0700 [thread overview]
Message-ID: <20220415134852.GA2271702@roeck-us.net> (raw)
In-Reply-To: <20220405234118.24830-1-rdunlap@infradead.org>
On Tue, Apr 05, 2022 at 04:41:18PM -0700, Randy Dunlap wrote:
> When CONFIG_DMASOUND_ATARI=m and CONFIG_DMASOUND_Q40=y (or vice versa),
> dmasound_core.o can be built without dmasound_deinit() being defined,
> causing a build error:
>
> ERROR: modpost: "dmasound_deinit" [sound/oss/dmasound/dmasound_atari.ko] undefined!
>
> Modify dmasound_core.c and dmasound.h so that dmasound_deinit() is
> always available.
>
> The mixed modes (=y/=m) also mean that several variables and structs
> have to be declared in all cases.
>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: lore.kernel.org/r/202204032138.EFT9qGEd-lkp@intel.com
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: alsa-devel@alsa-project.org
> ---
m68k:allmodconfig fails to build with this patch in the tree.
Error log:
sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used
... because __setup() is empty if MODULE is defined.
Guenter
next prev parent reply other threads:[~2022-04-15 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 23:41 Randy Dunlap
2022-04-07 8:29 ` Takashi Iwai
2022-04-15 13:48 ` Guenter Roeck [this message]
2022-04-15 14:45 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415134852.GA2271702@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®