From: Nishanth Menon <nm@ti.com>
To: Georgi Vlaev <g-vlaev@ti.com>
Cc: <ssantosh@kernel.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <robh+dt@kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 2/2] dt-bindings: clock: ehrpwm: Add AM62 specific compatible
Date: Fri, 15 Apr 2022 12:40:00 -0500 [thread overview]
Message-ID: <20220415174000.cnnmolsaktl7ghye@jurist> (raw)
In-Reply-To: <20220415134142.12141-3-g-vlaev@ti.com>
On 16:41-20220415, Georgi Vlaev wrote:
> Introduce AM62 specific compatible for EPWM time-base
> sub-module clock. The time-base clock setup is identical
> to AM64. The only difference is AM62 provides 3 time-base
> clocks instead of the 9 found in AM64.
>
> Signed-off-by: Georgi Vlaev <g-vlaev@ti.com>
> Tested-by: Vignesh Raghavendra <vigneshr@ti.com>
Reviewed-by: Nishanth Menon <nm@ti.com>
That said, please re-org the patches. Bindings come before the driver
changes :)
> ---
> .../devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> index 9b537bc876b5..66765116aff5 100644
> --- a/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> +++ b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> @@ -15,6 +15,7 @@ properties:
> - enum:
> - ti,am654-ehrpwm-tbclk
> - ti,am64-epwm-tbclk
> + - ti,am62-epwm-tbclk
> - const: syscon
>
> "#clock-cells":
> --
> 2.30.2
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
prev parent reply other threads:[~2022-04-15 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 13:41 [PATCH 0/2] clk: keystone: Add support for AM62 specific ewpm-tbclk Georgi Vlaev
2022-04-15 13:41 ` [PATCH 1/2] clk: keystone: syscon-clk: Add support for AM62 epwm-tbclk Georgi Vlaev
2022-04-15 13:41 ` [PATCH 2/2] dt-bindings: clock: ehrpwm: Add AM62 specific compatible Georgi Vlaev
2022-04-15 17:40 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415174000.cnnmolsaktl7ghye@jurist \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=g-vlaev@ti.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=ssantosh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®