From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64132C433EF for ; Sat, 16 Apr 2022 03:43:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230221AbiDPDpd (ORCPT ); Fri, 15 Apr 2022 23:45:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230195AbiDPDp1 (ORCPT ); Fri, 15 Apr 2022 23:45:27 -0400 Received: from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com [IPv6:2607:f8b0:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A823A145B for ; Fri, 15 Apr 2022 20:42:57 -0700 (PDT) Received: by mail-pg1-x54a.google.com with SMTP id n1-20020a654881000000b003a367d46721so869760pgs.4 for ; Fri, 15 Apr 2022 20:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=fTlZCEAeKXElMirgnXEOUiISDvu4kIw+3K3+/YC0tjY=; b=esGDB+uQK+XlvOzeTwh0mtq3egMCIieRH3ZRiipmzTx5/a4pNJQ2RmB2E4uDA2bNdy cnM+1TL1FiXBdKb+jMG/sq91sq/ZAxb3wtrUF1MYxoPD8QdpNqZr1rP1Cx9qI81Q9vX9 0VvWDxR8uRdpFT4pDstEyo/1RsBVBu+4tTPe/vhS0Ny19ZUSiiMUkOYzr4y2Vk7aKc02 YZB6PrlB5kKuiNM/RZ2jeeYKzMdHmYjycfKvMgpJKi5J17GZuRAjL5FMlFZewOu1c2BU +uL+WlGMzWHmlkrJ9FeEzj3aCBMHDlcyIJlegtO1tfNTBXJ2P7X4LWBPyExsQ9DS9nAr Gt7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=fTlZCEAeKXElMirgnXEOUiISDvu4kIw+3K3+/YC0tjY=; b=PpXgiE+YPbfBvJtnNrIjkSrffiQH/uSZ4DksIko7UyiU5yehsMLKqAO+qT4Nl4pYVt qO8C6HYH4PUHJjCqm0WTXrAKv/KjG2lFiw4ZODz5dzX5D0E87ajN0wxXPRbMQhhpdekT geF/4mnHLv4yjZdLbpuxPr2eou9Yod73totXnCBXtliUz2vEc1UpUuptcLEZXf21H+uo zoQCWjBn+kP1YfjKefcHJfYJ77/4reX3GAx9SwYDAq8V2ZCUs4pop7svDsaYwPiJqlH7 OOabDCsFx/hnptl7PX14HvWfzGnY8PDJKn+neAiJqBW4BxAGBRmmNL8+UtKxEUwMS8HC Ic9w== X-Gm-Message-State: AOAM530FHRBAK1gp3ZEFHqkraEMzubR1YXCivlChdzTL7VyZhGDbFUUr VzgcOrsaCU6zx6PjCDnqsKSxI1Lf7Ig= X-Google-Smtp-Source: ABdhPJwEvVzDPrTPEf7YMvmW/Px6daHU99c/ZLJCjUTC4jIXd4UhIM6/elOLB9r2p6vwqsgODRXNCYRQI9g= X-Received: from seanjc.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:3e5]) (user=seanjc job=sendgmr) by 2002:a05:6a00:ad0:b0:4e1:2d96:2ab0 with SMTP id c16-20020a056a000ad000b004e12d962ab0mr1879483pfl.3.1650080576657; Fri, 15 Apr 2022 20:42:56 -0700 (PDT) Reply-To: Sean Christopherson Date: Sat, 16 Apr 2022 03:42:46 +0000 In-Reply-To: <20220416034249.2609491-1-seanjc@google.com> Message-Id: <20220416034249.2609491-2-seanjc@google.com> Mime-Version: 1.0 References: <20220416034249.2609491-1-seanjc@google.com> X-Mailer: git-send-email 2.36.0.rc0.470.gd361397f0d-goog Subject: [PATCH 1/4] KVM: x86: Tag APICv DISABLE inhibit, not ABSENT, if APICv is disabled From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Gaoning Pan , Yongkang Jia , Maxim Levitsky Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Set the DISABLE inhibit, not the ABSENT inhibit, if APICv is disabled via module param. A recent refactoring to add a wrapper for setting/clearing inhibits unintentionally changed the flag, probably due to a copy+paste goof. Fixes: 4f4c4a3ee53c ("KVM: x86: Trace all APICv inhibit changes and capture overall status") Signed-off-by: Sean Christopherson --- arch/x86/kvm/x86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index ab336f7c82e4..753296902535 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -9159,7 +9159,7 @@ static void kvm_apicv_init(struct kvm *kvm) if (!enable_apicv) set_or_clear_apicv_inhibit(inhibits, - APICV_INHIBIT_REASON_ABSENT, true); + APICV_INHIBIT_REASON_DISABLE, true); } static void kvm_sched_yield(struct kvm_vcpu *vcpu, unsigned long dest_id) -- 2.36.0.rc0.470.gd361397f0d-goog