From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Baochen Qiang <quic_bqiang@quicinc.com>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
linux-kernel@vger.kernel.org, Kalle Valo <quic_kvalo@quicinc.com>
Subject: [ammarfaizi2-block:kvalo/ath/pending 36/40] drivers/net/wireless/ath/ath11k/mac.c:8293 ath11k_mac_op_set_bios_sar_specs() warn: variable dereferenced before check 'sar' (see line 8280)
Date: Fri, 22 Apr 2022 17:37:33 +0300 [thread overview]
Message-ID: <202204182315.h96VPgso-lkp@intel.com> (raw)
tree: https://github.com/ammarfaizi2/linux-block kvalo/ath/pending
head: c9a8efc35304a89fc0751649945909caf03eeb29
commit: 5ad5b356e75f402fec930cf0d77b6c7862850b55 [36/40] ath11k: Add support for SAR
config: x86_64-randconfig-m001-20220418 (https://download.01.org/0day-ci/archive/20220418/202204182315.h96VPgso-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/wireless/ath/ath11k/mac.c:8293 ath11k_mac_op_set_bios_sar_specs() warn: variable dereferenced before check 'sar' (see line 8280)
vim +/sar +8293 drivers/net/wireless/ath/ath11k/mac.c
5ad5b356e75f40 Baochen Qiang 2022-04-12 8276 static int ath11k_mac_op_set_bios_sar_specs(struct ieee80211_hw *hw,
5ad5b356e75f40 Baochen Qiang 2022-04-12 8277 const struct cfg80211_sar_specs *sar)
5ad5b356e75f40 Baochen Qiang 2022-04-12 8278 {
5ad5b356e75f40 Baochen Qiang 2022-04-12 8279 struct ath11k *ar = hw->priv;
5ad5b356e75f40 Baochen Qiang 2022-04-12 @8280 const struct cfg80211_sar_sub_specs *sspec = sar->sub_specs;
^^^^^^^^^^^^^^
Dereference
5ad5b356e75f40 Baochen Qiang 2022-04-12 8281 int ret, index;
5ad5b356e75f40 Baochen Qiang 2022-04-12 8282 u8 *sar_tbl;
5ad5b356e75f40 Baochen Qiang 2022-04-12 8283 u32 i;
5ad5b356e75f40 Baochen Qiang 2022-04-12 8284
5ad5b356e75f40 Baochen Qiang 2022-04-12 8285 mutex_lock(&ar->conf_mutex);
5ad5b356e75f40 Baochen Qiang 2022-04-12 8286
5ad5b356e75f40 Baochen Qiang 2022-04-12 8287 if (!test_bit(WMI_TLV_SERVICE_BIOS_SAR_SUPPORT, ar->ab->wmi_ab.svc_map) ||
5ad5b356e75f40 Baochen Qiang 2022-04-12 8288 !ar->ab->hw_params.bios_sar_capa) {
5ad5b356e75f40 Baochen Qiang 2022-04-12 8289 ret = -EOPNOTSUPP;
5ad5b356e75f40 Baochen Qiang 2022-04-12 8290 goto exit;
5ad5b356e75f40 Baochen Qiang 2022-04-12 8291 }
5ad5b356e75f40 Baochen Qiang 2022-04-12 8292
5ad5b356e75f40 Baochen Qiang 2022-04-12 @8293 if (!sar || sar->type != NL80211_SAR_TYPE_POWER ||
^^^
Checked too late
5ad5b356e75f40 Baochen Qiang 2022-04-12 8294 sar->num_sub_specs == 0) {
5ad5b356e75f40 Baochen Qiang 2022-04-12 8295 ret = -EINVAL;
5ad5b356e75f40 Baochen Qiang 2022-04-12 8296 goto exit;
5ad5b356e75f40 Baochen Qiang 2022-04-12 8297 }
5ad5b356e75f40 Baochen Qiang 2022-04-12 8298
5ad5b356e75f40 Baochen Qiang 2022-04-12 8299 ret = ath11k_wmi_pdev_set_bios_geo_table_param(ar);
5ad5b356e75f40 Baochen Qiang 2022-04-12 8300 if (ret) {
5ad5b356e75f40 Baochen Qiang 2022-04-12 8301 ath11k_warn(ar->ab, "failed to set geo table: %d\n", ret);
5ad5b356e75f40 Baochen Qiang 2022-04-12 8302 goto exit;
5ad5b356e75f40 Baochen Qiang 2022-04-12 8303 }
5ad5b356e75f40 Baochen Qiang 2022-04-12 8304
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next reply other threads:[~2022-04-22 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 14:37 Dan Carpenter [this message]
2022-04-27 11:19 ` Kalle Valo
2022-04-27 11:55 ` Baochen Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204182315.h96VPgso-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=gwml@vger.gnuweeb.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=quic_bqiang@quicinc.com \
--cc=quic_kvalo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®