From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53230C433EF for ; Tue, 19 Apr 2022 00:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237679AbiDSAH1 (ORCPT ); Mon, 18 Apr 2022 20:07:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229920AbiDSAGK (ORCPT ); Mon, 18 Apr 2022 20:06:10 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A06C1FA7E; Mon, 18 Apr 2022 17:03:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 61FA1B81142; Tue, 19 Apr 2022 00:03:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5655AC385CB; Tue, 19 Apr 2022 00:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650326605; bh=UYudwu1QrF7TbcsMmA2KTg1pYLeL053zgVc8k9emey8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F0KjUbQ6RmtdKOR9u22u/p1b8WtaU3OW9MgNbw68SjOFVxyrgJ14FEVxnqaJTDdkm IeFMPr7qYL1SN4hcRLnBT0kKRKSVltLRibOhKu9HYwf+HVI1NIl3jk9eKOTV0GpsYO 6wZoWy6NeAsN4tYzLXbYhcKyqSYcc63GaANK/+DGz6DuSAgdVIUgs+E5ljAzbuwnQ4 9N/2I9aIRJkAxZtRV+vp/1NQqOg3E6jeLSWcSbYvB261tkxR0Uettttmrzzc5nnwl2 CFx/iFR1vwiGQ93Nvhcd6ZjPeBHvJnNiIAyvlxEVni1mgYf4QnDRIkbtMKpY4AIICA HxMheCjm7gRDA== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 72BA55C30EA; Mon, 18 Apr 2022 17:03:24 -0700 (PDT) From: "Paul E. McKenney" To: rcu@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, rostedt@goodmis.org, Lukas Bulwahn , "Paul E . McKenney" Subject: [PATCH rcu 21/21] srcu: Drop needless initialization of sdp in srcu_gp_start() Date: Mon, 18 Apr 2022 17:03:22 -0700 Message-Id: <20220419000322.3948903-21-paulmck@kernel.org> X-Mailer: git-send-email 2.31.1.189.g2e36527f23 In-Reply-To: <20220419000315.GA3948789@paulmck-ThinkPad-P17-Gen-1> References: <20220419000315.GA3948789@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lukas Bulwahn Commit 9c7ef4c30f12 ("srcu: Make Tree SRCU able to operate without snp_node array") initializes the local variable sdp differently depending on the srcu's state in srcu_gp_start(). Either way, this initialization overwrites the value used when sdp is defined. This commit therefore drops this pointless definition-time initialization. Although there is no functional change, compiler code generation may be affected. Signed-off-by: Lukas Bulwahn Signed-off-by: Paul E. McKenney --- kernel/rcu/srcutree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c index 6dd44e759f12..50ba70f019de 100644 --- a/kernel/rcu/srcutree.c +++ b/kernel/rcu/srcutree.c @@ -620,7 +620,7 @@ EXPORT_SYMBOL_GPL(__srcu_read_unlock); */ static void srcu_gp_start(struct srcu_struct *ssp) { - struct srcu_data *sdp = this_cpu_ptr(ssp->sda); + struct srcu_data *sdp; int state; if (smp_load_acquire(&ssp->srcu_size_state) < SRCU_SIZE_WAIT_BARRIER) -- 2.31.1.189.g2e36527f23