From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F46FC433FE for ; Tue, 19 Apr 2022 23:56:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355442AbiDSX7R (ORCPT ); Tue, 19 Apr 2022 19:59:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230177AbiDSX7M (ORCPT ); Tue, 19 Apr 2022 19:59:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C86041D338; Tue, 19 Apr 2022 16:56:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E0235612C9; Tue, 19 Apr 2022 23:56:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E5F2C385A5; Tue, 19 Apr 2022 23:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650412587; bh=9g7/inwTumUIZwXW1gRuGutp+YxXGAnaNf9dgVpIOmc=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=boFsQlzFH9xlyHfZyVvNVFOGqef8ImZ53V94HwpRC5UE7lMhH56ABug6C98jSeIi0 zxRR2O1bzcGNGmUMYW7BYp6flp70sbLb4IuShY2cIweFy8hwjq4fKZ972zjKZi1mOO pr1EUnI8nYnet6eKlv7rlP9KK89lQ0LvN18cwVt0ADtWj1shSbj9y8LmozLaK4wC/B VNNlsHrjfprNXXGPlXIBPZtEB/1iOb99uSFm4fxFBzjgtMReR9tAvOdCiqKof9aVyJ 4jrYXFz1i1+z23Ap6tsiXJdXJWOKjwcg/8FV9DbRPEE//hIXO+RRusifgIXHb8PvKR x6KuWYo44SlHA== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id D953F5C012F; Tue, 19 Apr 2022 16:56:26 -0700 (PDT) Date: Tue, 19 Apr 2022 16:56:26 -0700 From: "Paul E. McKenney" To: Joel Fernandes Cc: LKML , Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , rcu , Steven Rostedt , Rushikesh S Kadam , Vineeth Pillai , "Uladzislau Rezki (Sony)" Subject: Re: [PATCH v4 rcu/dev] rcu/nocb: Add an option to offload all CPUs on boot Message-ID: <20220419235626.GW4285@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20220419200823.2790490-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 19, 2022 at 04:10:33PM -0400, Joel Fernandes wrote: > On Tue, Apr 19, 2022 at 4:08 PM Joel Fernandes (Google) > wrote: > > > > From: Joel Fernandes > > > > On systems with CONFIG_RCU_NOCB_CPU=y, there is no default mask provided > > which ends up not offloading any CPU. This patch removes a dependency > > from the bootloader having to know about RCU and about how to provide > > the mask. > > > > With the new option enabled, all CPUs will be offloaded on boot unless > > rcu_nocbs= or rcu_nohz_full= kernel parameters provide a CPU list. > > > > Signed-off-by: Joel Fernandes > > Oops, forgot to add Reviewed-by tags: > Reviewed-by: Uladzislau Rezki (Sony) > Reviewed-by: Kalesh Singh > > Paul, would you mind doing so, so I don't have to resend? Apologies. OK, but only because it passed an allmodconfig build this time. ;-) Thanx, Paul > Thanks, > > Joel > > > > --- > > v4: Rebased on rcu/dev, fixed conflict with Frederick's patch changing > > location of nocb_is_setup variable. > > > > Documentation/admin-guide/kernel-parameters.txt | 6 ++++++ > > kernel/rcu/Kconfig | 13 +++++++++++++ > > kernel/rcu/tree_nocb.h | 13 +++++++++++++ > > 3 files changed, 32 insertions(+) > > > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > > index 789ef586009b..1e82ecb7a649 100644 > > --- a/Documentation/admin-guide/kernel-parameters.txt > > +++ b/Documentation/admin-guide/kernel-parameters.txt > > @@ -3572,6 +3572,9 @@ > > just as if they had also been called out in the > > rcu_nocbs= boot parameter. > > > > + Note that this argument takes precedence over > > + the CONFIG_RCU_NOCB_CPU_DEFAULT_ALL option. > > + > > noiotrap [SH] Disables trapped I/O port accesses. > > > > noirqdebug [X86-32] Disables the code which attempts to detect and > > @@ -4475,6 +4478,9 @@ > > no-callback mode from boot but the mode may be > > toggled at runtime via cpusets. > > > > + Note that this argument takes precedence over > > + the CONFIG_RCU_NOCB_CPU_DEFAULT_ALL option. > > + > > rcu_nocb_poll [KNL] > > Rather than requiring that offloaded CPUs > > (specified by rcu_nocbs= above) explicitly > > diff --git a/kernel/rcu/Kconfig b/kernel/rcu/Kconfig > > index 1c630e573548..27aab870ae4c 100644 > > --- a/kernel/rcu/Kconfig > > +++ b/kernel/rcu/Kconfig > > @@ -262,6 +262,19 @@ config RCU_NOCB_CPU > > Say Y here if you need reduced OS jitter, despite added overhead. > > Say N here if you are unsure. > > > > +config RCU_NOCB_CPU_DEFAULT_ALL > > + bool "Offload RCU callback processing from all CPUs by default" > > + depends on RCU_NOCB_CPU > > + default n > > + help > > + Use this option to offload callback processing from all CPUs > > + by default, in the absence of the rcu_nocbs or nohz_full boot > > + parameter. This also avoids the need to use any boot parameters > > + to achieve the effect of offloading all CPUs on boot. > > + > > + Say Y here if you want offload all CPUs by default on boot. > > + Say N here if you are unsure. > > + > > config TASKS_TRACE_RCU_READ_MB > > bool "Tasks Trace RCU readers use memory barriers in user and idle" > > depends on RCU_EXPERT && TASKS_TRACE_RCU > > diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h > > index 4cf9a29bba79..9f29f25a0cbc 100644 > > --- a/kernel/rcu/tree_nocb.h > > +++ b/kernel/rcu/tree_nocb.h > > @@ -1197,11 +1197,21 @@ void __init rcu_init_nohz(void) > > { > > int cpu; > > bool need_rcu_nocb_mask = false; > > + bool offload_all = false; > > struct rcu_data *rdp; > > > > +#if defined(CONFIG_RCU_NOCB_CPU_DEFAULT_ALL) > > + if (!rcu_state.nocb_is_setup) { > > + need_rcu_nocb_mask = true; > > + offload_all = true; > > + } > > +#endif /* #if defined(CONFIG_RCU_NOCB_CPU_DEFAULT_ALL) */ > > + > > #if defined(CONFIG_NO_HZ_FULL) > > if (tick_nohz_full_running && !cpumask_empty(tick_nohz_full_mask)) > > need_rcu_nocb_mask = true; > > + offload_all = false; /* NO_HZ_FULL has its own mask. */ > > + } > > #endif /* #if defined(CONFIG_NO_HZ_FULL) */ > > > > if (need_rcu_nocb_mask) { > > @@ -1222,6 +1232,9 @@ void __init rcu_init_nohz(void) > > cpumask_or(rcu_nocb_mask, rcu_nocb_mask, tick_nohz_full_mask); > > #endif /* #if defined(CONFIG_NO_HZ_FULL) */ > > > > + if (offload_all) > > + cpumask_setall(rcu_nocb_mask); > > + > > if (!cpumask_subset(rcu_nocb_mask, cpu_possible_mask)) { > > pr_info("\tNote: kernel parameter 'rcu_nocbs=', 'nohz_full', or 'isolcpus=' contains nonexistent CPUs.\n"); > > cpumask_and(rcu_nocb_mask, cpu_possible_mask, > > -- > > 2.36.0.rc0.470.gd361397f0d-goog > >