From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60DF9C433FE for ; Wed, 20 Apr 2022 01:37:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358780AbiDTBkY (ORCPT ); Tue, 19 Apr 2022 21:40:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358765AbiDTBkU (ORCPT ); Tue, 19 Apr 2022 21:40:20 -0400 Received: from mail-pl1-x64a.google.com (mail-pl1-x64a.google.com [IPv6:2607:f8b0:4864:20::64a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1DEB3467E for ; Tue, 19 Apr 2022 18:37:36 -0700 (PDT) Received: by mail-pl1-x64a.google.com with SMTP id ij17-20020a170902ab5100b00158f6f83068so135049plb.19 for ; Tue, 19 Apr 2022 18:37:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=7XDJ2YAUSUHcgoV3YPLSl5Gau4y2D+i+qP4k1W8uuo0=; b=Kzq671IMXGcPz9IKQMcDM3US3HjfGCUincXTuSeb8zoQ5g9zspDa+oftBodD+68BA0 ASknvWT3y3/2tm1pFvOJJf03UDGsxHlo9HiJfajn1z86XFO8VOYNgeJSfcldOjJttKL6 u4iQvkpiuIkouUmlKxAkJZjsKSp4mgT8LCkPtIuNgcc2wJgdk6U7HVc6zawUrxFqpmSh cJMdz7quOHZhIjj/TZfU2uKppIHeoeY4vyOXo7g77A40z8OFTcPn3la8QqxicZn1Y0I2 coWmIbo0WusRrVIVoc6e2zWzddbvtftv+F4nVGPrWzvz4itxs6rqqz4CFy1AZrhnF+s1 VKiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=7XDJ2YAUSUHcgoV3YPLSl5Gau4y2D+i+qP4k1W8uuo0=; b=kDQEts+GWQydUA2WWWsWmBrOz5YBaUR/2Mlr9fFZjqj9cBDJex4i3JtNF9kydN7SE0 rIkBJNqRfVxFgzmQ8Fq4djG+zedM5rFuKFlz1YJ7tAl2og7PYeQ9biDDb1uv++9mDY1g QfZggTKGpp08fQGJlJ4548jyMj9szvuEQo2bIt7QXYXLPp0uQY63uHwyi1xEtYOGf2cc 2a/6YMdJ12vE//6yQa2OdRW/C2CAjpXGS9VSH/yAdxfq6IZViK3IPhkwFO41Z8gbfOZJ GNz+eLd4MbHgvIO1zdfQ/jb8gR5LDmt8u+cXnBULxukMV5jVpfgHla62tJmZk3d2XkA+ OQLw== X-Gm-Message-State: AOAM532cG7dbPvW/d5D0ZPimRIRBf7HCyad/D4VGRyCIqPqDVQUkoxD4 0R+PaPnzuCx6X2p2pICGG8Lm6ofuyTk= X-Google-Smtp-Source: ABdhPJxuyNZSwYUgGu63fLJ8gbeXdplf35syAz3Hcvk6YC/6aaKdyYPIGOcMr0sABs2XFp+PY2pmPdIXT+g= X-Received: from seanjc.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:3e5]) (user=seanjc job=sendgmr) by 2002:a17:90a:9105:b0:1d2:9e98:7e1e with SMTP id k5-20020a17090a910500b001d29e987e1emr198610pjo.0.1650418655862; Tue, 19 Apr 2022 18:37:35 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 20 Apr 2022 01:37:29 +0000 In-Reply-To: <20220420013732.3308816-1-seanjc@google.com> Message-Id: <20220420013732.3308816-2-seanjc@google.com> Mime-Version: 1.0 References: <20220420013732.3308816-1-seanjc@google.com> X-Mailer: git-send-email 2.36.0.rc0.470.gd361397f0d-goog Subject: [PATCH v2 1/4] KVM: x86: Tag APICv DISABLE inhibit, not ABSENT, if APICv is disabled From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Maxim Levitsky , Gaoning Pan , Yongkang Jia Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Set the DISABLE inhibit, not the ABSENT inhibit, if APICv is disabled via module param. A recent refactoring to add a wrapper for setting/clearing inhibits unintentionally changed the flag, probably due to a copy+paste goof. Fixes: 4f4c4a3ee53c ("KVM: x86: Trace all APICv inhibit changes and capture overall status") Signed-off-by: Sean Christopherson Reviewed-by: Maxim Levitsky --- arch/x86/kvm/x86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index ab336f7c82e4..753296902535 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -9159,7 +9159,7 @@ static void kvm_apicv_init(struct kvm *kvm) if (!enable_apicv) set_or_clear_apicv_inhibit(inhibits, - APICV_INHIBIT_REASON_ABSENT, true); + APICV_INHIBIT_REASON_DISABLE, true); } static void kvm_sched_yield(struct kvm_vcpu *vcpu, unsigned long dest_id) -- 2.36.0.rc0.470.gd361397f0d-goog