From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, mbenes@suse.cz
Subject: Re: [PATCH 2/2] objtool: Fix code relocs vs weak symbols
Date: Tue, 19 Apr 2022 19:16:01 -0700 [thread overview]
Message-ID: <20220420021601.kiughdji3avh2uua@treble> (raw)
In-Reply-To: <20220419203807.655552918@infradead.org>
On Tue, Apr 19, 2022 at 10:32:56PM +0200, Peter Zijlstra wrote:
> + /* XXX create ? */
> + if (symtab_shndx) {
Not sure what this comment means?
Otherwise both patches look good to me. Let me run it through some
tests.
--
Josh
next prev parent reply other threads:[~2022-04-20 2:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 20:32 [PATCH 0/2] objtool: Fix code reloc " Peter Zijlstra
2022-04-19 20:32 ` [PATCH 1/2] objtool: Fix type of reloc::addend Peter Zijlstra
2022-04-22 10:27 ` [tip: objtool/urgent] " tip-bot2 for Peter Zijlstra
2022-04-19 20:32 ` [PATCH 2/2] objtool: Fix code relocs vs weak symbols Peter Zijlstra
2022-04-20 2:16 ` Josh Poimboeuf [this message]
2022-04-20 6:57 ` Peter Zijlstra
2022-04-22 10:27 ` [tip: objtool/urgent] " tip-bot2 for Peter Zijlstra
2022-04-21 15:48 ` [PATCH 0/2] objtool: Fix code reloc " Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420021601.kiughdji3avh2uua@treble \
--to=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®