From: Jan Kara <jack@suse.cz>
To: Phi Nguyen <phind.uet@gmail.com>
Cc: syzbot <syzbot+c7358a3cd05ee786eb31@syzkaller.appspotmail.com>,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, tytso@mit.edu
Subject: Re: [syzbot] kernel BUG in ext4_es_cache_extent
Date: Wed, 20 Apr 2022 14:16:26 +0200 [thread overview]
Message-ID: <20220420121626.edhvfibz4n3trnvg@quack3.lan> (raw)
In-Reply-To: <e58c5085-c351-a7a6-fe97-3da6eb1a804f@gmail.com>
On Mon 14-02-22 02:03:37, Phi Nguyen wrote:
> The non-journal mounted fs is corrupted, syzbot was able to mount it because
> a [fast commit] patch exclude its inodes from verification process.
>
> #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
This patch seems to have fallen through the cracks. Phi, care to submit it
properly with your Signed-off-by etc?
Honza
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 01c9e4f743ba..385f4ae71573 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -4912,7 +4912,7 @@ struct inode *__ext4_iget(struct super_block *sb, unsigned long ino,
> goto bad_inode;
> } else if (!ext4_has_inline_data(inode)) {
> /* validate the block references in the inode */
> - if (!(EXT4_SB(sb)->s_mount_state & EXT4_FC_REPLAY) &&
> + if (!(journal && EXT4_SB(sb)->s_mount_state & EXT4_FC_REPLAY) &&
> (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
> (S_ISLNK(inode->i_mode) &&
> !ext4_inode_is_fast_symlink(inode)))) {
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2022-04-20 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 13:49 syzbot
2022-02-13 18:03 ` Phi Nguyen
2022-02-13 23:39 ` syzbot
2022-04-20 12:16 ` Jan Kara [this message]
2022-04-20 13:57 ` Phi Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420121626.edhvfibz4n3trnvg@quack3.lan \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phind.uet@gmail.com \
--cc=syzbot+c7358a3cd05ee786eb31@syzkaller.appspotmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®