From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, brgerst@gmail.com, jiangshanlai@gmail.com,
Andrew.Cooper3@citrix.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: Simplify Retpoline thunk
Date: Wed, 20 Apr 2022 08:27:36 -0700 [thread overview]
Message-ID: <20220420152736.qzl3nikds6mq5nrr@treble> (raw)
In-Reply-To: <20220419205241.280037046@infradead.org>
On Tue, Apr 19, 2022 at 10:41:10PM +0200, Peter Zijlstra wrote:
> Now that we rewrite all the indirect call sites, per commit:
>
> 750850090081 ("x86/alternative: Implement .retpoline_sites support")
>
> it doesn't make sense to have the retpoline thunks be an ALTERNATIVE_2
> that still includes a 'naked' indirect jump.
>
> (this accidentally 'defunnels' i386 by going back to full retpolines)
So mitigations=off no longer works on i386?
Is funneling even a concern on i386? I don't think it has eIBRS anyway,
or does it?
--
Josh
next prev parent reply other threads:[~2022-04-20 15:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 20:41 [PATCH 0/2] x86: A few random cleanups Peter Zijlstra
2022-04-19 20:41 ` [PATCH 1/2] x86: Simplify Retpoline thunk Peter Zijlstra
2022-04-20 15:27 ` Josh Poimboeuf [this message]
2022-04-20 15:51 ` Peter Zijlstra
2022-04-20 16:01 ` Josh Poimboeuf
2022-04-19 20:41 ` [PATCH 2/2] x86,entry: Use PUSH_AND_CLEAR_REGS for compat Peter Zijlstra
2022-04-20 3:21 ` Josh Poimboeuf
2022-04-20 7:07 ` Peter Zijlstra
2022-04-20 14:58 ` Josh Poimboeuf
2022-04-20 4:29 ` Lai Jiangshan
2022-04-20 14:26 ` Andy Lutomirski
2022-04-20 14:51 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420152736.qzl3nikds6mq5nrr@treble \
--to=jpoimboe@redhat.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=brgerst@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®