From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05665C433F5 for ; Wed, 20 Apr 2022 20:36:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379800AbiDTUi5 (ORCPT ); Wed, 20 Apr 2022 16:38:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232987AbiDTUix (ORCPT ); Wed, 20 Apr 2022 16:38:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB5A42ED68; Wed, 20 Apr 2022 13:36:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7C054B82192; Wed, 20 Apr 2022 20:36:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3086FC385A1; Wed, 20 Apr 2022 20:36:02 +0000 (UTC) Date: Wed, 20 Apr 2022 16:36:00 -0400 From: Steven Rostedt To: Joel Fernandes Cc: "Paul E. McKenney" , LKML , Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , rcu , Frederic Weisbecker Subject: Re: [PATCH RFC] rcu/nocb: Provide default all-CPUs mask for RCU_NOCB_CPU=y Message-ID: <20220420163600.18b9cd15@gandalf.local.home> In-Reply-To: References: <20220408205440.GL4285@paulmck-ThinkPad-P17-Gen-1> <20220411154109.GX4285@paulmck-ThinkPad-P17-Gen-1> <20220414194204.GU4285@paulmck-ThinkPad-P17-Gen-1> <20220414210933.GW4285@paulmck-ThinkPad-P17-Gen-1> <20220414213156.GZ4285@paulmck-ThinkPad-P17-Gen-1> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Apr 2022 17:38:08 -0400 Joel Fernandes wrote: > Then it should be called: CONFIG_RCU_NOCB_CPU_DEFAULT_ALL , or > something. Otherwise I can tell you that I will be the first one to be > confused by menuconfig unless I also read the code :-D Naw, I think calling it CONFIG_RCU_NOCB_CPU_ALL is fine, it's what you write in the help message of the Kconfig file that really matters. I would always say that what is on the command line should override the configs (when feasible). To add something to the command line takes effort, and is always visible (cat /proc/cmdline), whereas configs are hidden and not as visible to those using the kernel. Not having the command line work would be annoying, and even if it came up with a message of "The config says *all* so I'm ignoring what you want to do" would be exceptionally more annoying as now the user has to recompile the kernel (and only if they could). -- Steve