From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8559FC433FE for ; Thu, 21 Apr 2022 22:26:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442453AbiDUW3s (ORCPT ); Thu, 21 Apr 2022 18:29:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230188AbiDUW3q (ORCPT ); Thu, 21 Apr 2022 18:29:46 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92D784A909 for ; Thu, 21 Apr 2022 15:26:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650580015; x=1682116015; h=date:from:to:cc:subject:message-id:mime-version; bh=iDUNii+0PdRNZrXW0OG7qb8gCoVEuCpUOWSO6u45rFM=; b=JR+Ycs8bD2q3BRNyUpTBjIclwtAb3xLDkTGumFYJ5xbEtp6ePumFTWob pvhXNdBIhMIoE9Wrv3ZvASTYZ2KqG4kyxI7nXIw3m15wzZ9MvTiq/LM6r W6IpLqasqhMOZ1cQVUITyyUPuYrTZIJnL7dluteuGaGdymBBD8xwHy/xX jz5CElT/IVnEPJkK5qrto+CwQ6tMDW2Zg3+owjJMMn+Cf48unT1dc3mnP loDlkvC9pe3sC5B/8yO4KiW8VTdjd8Eha5DrKnEWC1j3t0o4NFpqSPqRZ oHpUlqeGEvnoW1WpU12w6wJ+1AwNCKoiGBoGuQxGUOoNSWVR8UQ0IyYR5 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="289614024" X-IronPort-AV: E=Sophos;i="5.90,279,1643702400"; d="scan'208";a="289614024" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2022 15:26:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,279,1643702400"; d="scan'208";a="671382756" Received: from lkp-server01.sh.intel.com (HELO 3abc53900bec) ([10.239.97.150]) by orsmga004.jf.intel.com with ESMTP; 21 Apr 2022 15:26:51 -0700 Received: from kbuild by 3abc53900bec with local (Exim 4.95) (envelope-from ) id 1nhfGE-0008qY-H0; Thu, 21 Apr 2022 22:26:50 +0000 Date: Fri, 22 Apr 2022 06:25:51 +0800 From: kernel test robot To: Srikar Dronamraju Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Michael Ellerman , Sasha Levin Subject: [stable:linux-5.10.y 499/5321] arch/powerpc/kernel/smp.c:1380:14: error: variable 'ret' set but not used Message-ID: <202204220615.hpSQ4muZ-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Srikar, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.10.y head: 1052f9bce62982023737a95b7ff1ad26a5149af6 commit: e91077cf1780108dc586cedf1d19f65b44fa3870 [499/5321] powerpc/smp: Update cpu_core_map on all PowerPc systems config: powerpc-iss476-smp_defconfig (https://download.01.org/0day-ci/archive/20220422/202204220615.hpSQ4muZ-lkp@intel.com/config) compiler: powerpc-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=e91077cf1780108dc586cedf1d19f65b44fa3870 git remote add stable https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git git fetch --no-tags stable linux-5.10.y git checkout e91077cf1780108dc586cedf1d19f65b44fa3870 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): arch/powerpc/kernel/smp.c:551:6: error: no previous prototype for 'tick_broadcast' [-Werror=missing-prototypes] 551 | void tick_broadcast(const struct cpumask *mask) | ^~~~~~~~~~~~~~ arch/powerpc/kernel/smp.c: In function 'add_cpu_to_masks': >> arch/powerpc/kernel/smp.c:1380:14: error: variable 'ret' set but not used [-Werror=unused-but-set-variable] 1380 | bool ret; | ^~~ cc1: all warnings being treated as errors Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for HOTPLUG_CPU Depends on SMP && (PPC_PSERIES || PPC_PMAC || PPC_POWERNV || FSL_SOC_BOOKE Selected by - PM_SLEEP_SMP && SMP && (ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE && PM_SLEEP vim +/ret +1380 arch/powerpc/kernel/smp.c b8a97cb4599cda Srikar Dronamraju 2020-09-21 1373 df52f6714071c4 Oliver O'Halloran 2017-06-29 1374 static void add_cpu_to_masks(int cpu) df52f6714071c4 Oliver O'Halloran 2017-06-29 1375 { bf6476152a0a08 Srikar Dronamraju 2021-04-15 1376 struct cpumask *(*submask_fn)(int) = cpu_sibling_mask; df52f6714071c4 Oliver O'Halloran 2017-06-29 1377 int first_thread = cpu_first_thread_sibling(cpu); bf6476152a0a08 Srikar Dronamraju 2021-04-15 1378 int chip_id = cpu_to_chip_id(cpu); 84dbf66c634720 Srikar Dronamraju 2020-10-19 1379 cpumask_var_t mask; bf6476152a0a08 Srikar Dronamraju 2021-04-15 @1380 bool ret; df52f6714071c4 Oliver O'Halloran 2017-06-29 1381 int i; df52f6714071c4 Oliver O'Halloran 2017-06-29 1382 df52f6714071c4 Oliver O'Halloran 2017-06-29 1383 /* df52f6714071c4 Oliver O'Halloran 2017-06-29 1384 * This CPU will not be in the online mask yet so we need to manually df52f6714071c4 Oliver O'Halloran 2017-06-29 1385 * add it to it's own thread sibling mask. df52f6714071c4 Oliver O'Halloran 2017-06-29 1386 */ df52f6714071c4 Oliver O'Halloran 2017-06-29 1387 cpumask_set_cpu(cpu, cpu_sibling_mask(cpu)); e91077cf178010 Srikar Dronamraju 2021-08-26 1388 cpumask_set_cpu(cpu, cpu_core_mask(cpu)); df52f6714071c4 Oliver O'Halloran 2017-06-29 1389 df52f6714071c4 Oliver O'Halloran 2017-06-29 1390 for (i = first_thread; i < first_thread + threads_per_core; i++) df52f6714071c4 Oliver O'Halloran 2017-06-29 1391 if (cpu_online(i)) df52f6714071c4 Oliver O'Halloran 2017-06-29 1392 set_cpus_related(i, cpu, cpu_sibling_mask); df52f6714071c4 Oliver O'Halloran 2017-06-29 1393 425752c63b6f3f Gautham R. Shenoy 2018-10-11 1394 add_cpu_to_smallcore_masks(cpu); 84dbf66c634720 Srikar Dronamraju 2020-10-19 1395 84dbf66c634720 Srikar Dronamraju 2020-10-19 1396 /* In CPU-hotplug path, hence use GFP_ATOMIC */ bf6476152a0a08 Srikar Dronamraju 2021-04-15 1397 ret = alloc_cpumask_var_node(&mask, GFP_ATOMIC, cpu_to_node(cpu)); 84dbf66c634720 Srikar Dronamraju 2020-10-19 1398 update_mask_by_l2(cpu, &mask); 2a636a56d2d396 Oliver O'Halloran 2017-06-29 1399 b8a97cb4599cda Srikar Dronamraju 2020-09-21 1400 if (has_coregroup_support()) 84dbf66c634720 Srikar Dronamraju 2020-10-19 1401 update_coregroup_mask(cpu, &mask); 84dbf66c634720 Srikar Dronamraju 2020-10-19 1402 bf6476152a0a08 Srikar Dronamraju 2021-04-15 1403 if (shared_caches) bf6476152a0a08 Srikar Dronamraju 2021-04-15 1404 submask_fn = cpu_l2_cache_mask; bf6476152a0a08 Srikar Dronamraju 2021-04-15 1405 bf6476152a0a08 Srikar Dronamraju 2021-04-15 1406 /* Update core_mask with all the CPUs that are part of submask */ bf6476152a0a08 Srikar Dronamraju 2021-04-15 1407 or_cpumasks_related(cpu, cpu, submask_fn, cpu_core_mask); bf6476152a0a08 Srikar Dronamraju 2021-04-15 1408 bf6476152a0a08 Srikar Dronamraju 2021-04-15 1409 /* Skip all CPUs already part of current CPU core mask */ bf6476152a0a08 Srikar Dronamraju 2021-04-15 1410 cpumask_andnot(mask, cpu_online_mask, cpu_core_mask(cpu)); bf6476152a0a08 Srikar Dronamraju 2021-04-15 1411 e91077cf178010 Srikar Dronamraju 2021-08-26 1412 /* If chip_id is -1; limit the cpu_core_mask to within DIE*/ e91077cf178010 Srikar Dronamraju 2021-08-26 1413 if (chip_id == -1) e91077cf178010 Srikar Dronamraju 2021-08-26 1414 cpumask_and(mask, mask, cpu_cpu_mask(cpu)); e91077cf178010 Srikar Dronamraju 2021-08-26 1415 bf6476152a0a08 Srikar Dronamraju 2021-04-15 1416 for_each_cpu(i, mask) { bf6476152a0a08 Srikar Dronamraju 2021-04-15 1417 if (chip_id == cpu_to_chip_id(i)) { bf6476152a0a08 Srikar Dronamraju 2021-04-15 1418 or_cpumasks_related(cpu, i, submask_fn, cpu_core_mask); bf6476152a0a08 Srikar Dronamraju 2021-04-15 1419 cpumask_andnot(mask, mask, submask_fn(i)); bf6476152a0a08 Srikar Dronamraju 2021-04-15 1420 } else { bf6476152a0a08 Srikar Dronamraju 2021-04-15 1421 cpumask_andnot(mask, mask, cpu_core_mask(i)); bf6476152a0a08 Srikar Dronamraju 2021-04-15 1422 } bf6476152a0a08 Srikar Dronamraju 2021-04-15 1423 } bf6476152a0a08 Srikar Dronamraju 2021-04-15 1424 84dbf66c634720 Srikar Dronamraju 2020-10-19 1425 free_cpumask_var(mask); a8a5356cd511db Paul Mackerras 2013-08-12 1426 } a8a5356cd511db Paul Mackerras 2013-08-12 1427 :::::: The code at line 1380 was first introduced by commit :::::: bf6476152a0a084038b12b9d770e32717f54a6ab powerpc/smp: Reintroduce cpu_core_mask :::::: TO: Srikar Dronamraju :::::: CC: Greg Kroah-Hartman -- 0-DAY CI Kernel Test Service https://01.org/lkp