From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Yann Gautier <yann.gautier@foss.st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [Linux-stm32] [PATCH v1 2/2] ARM: dts: stm32: add support for Protonic PRTT1x boards
Date: Fri, 22 Apr 2022 09:10:25 +0200 [thread overview]
Message-ID: <20220422071025.GC5244@pengutronix.de> (raw)
In-Reply-To: <37ba2977-848a-19a6-8505-279f2b19c962@foss.st.com>
On Thu, Apr 21, 2022 at 03:11:41PM +0200, Yann Gautier wrote:
> > +&sdmmc2 {
> > + pinctrl-names = "default", "opendrain", "sleep";
> > + pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_a>;
> > + pinctrl-1 = <&sdmmc2_b4_od_pins_a &sdmmc2_d47_pins_a>;
> > + pinctrl-2 = <&sdmmc2_b4_sleep_pins_a &sdmmc2_d47_sleep_pins_a>;
>
> Hi Oleksij,
>
> > + disable-wp;
> This is not used for eMMC (or SDIO), it can be removed.
>
> > + disable-cd;
> This property does not exist.
>
> > + none-removable;
> The right name is non-removable.
OK, thank you for review. I'll send v2
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2022-04-22 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 9:19 [PATCH v1 1/2] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards Oleksij Rempel
2022-04-21 9:19 ` [PATCH v1 2/2] ARM: dts: stm32: add support for Protonic PRTT1x boards Oleksij Rempel
2022-04-21 13:11 ` [Linux-stm32] " Yann Gautier
2022-04-22 7:10 ` Oleksij Rempel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220422071025.GC5244@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yann.gautier@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®