From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FAA4C433EF for ; Fri, 22 Apr 2022 07:56:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1445327AbiDVH7H (ORCPT ); Fri, 22 Apr 2022 03:59:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1445176AbiDVH61 (ORCPT ); Fri, 22 Apr 2022 03:58:27 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 171EB37A95; Fri, 22 Apr 2022 00:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650614135; x=1682150135; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bybU1LR0dCz2wUxGc5274gqzruD0/zCUSImGb6leP60=; b=JR3OvltVPrPzQr/ZbUAhhmyZ4VE/DUsIlxPHOxH7DlVbvYh9YhQQaELf SjEwhlpHMqeelYGP6EbgNGG6ws5BAQYzy7sUtPNuKCXxLWnZS5rtRFu/q u+Ne08BxKWb+eMd16ABHeEvvpJ2QqCfmhwYt0l8+5JsbsuqOr8kGX0XDN mCfvIlFNUiQnRhH7qDFzu3AdUi4waBoUUmsW93dPzDYbCWxJx20vpgBLj D86lQnE+19gDvZQObMI7fiNdVV7pfvYtcAwb9owpV/Bi1q+EY024VnQDj T+19yz38Op6qVmhKDQPdRheVp7NcRcKEjUMjw8rfk/LECPlhRhk91qdrA A==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="264384829" X-IronPort-AV: E=Sophos;i="5.90,281,1643702400"; d="scan'208";a="264384829" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2022 00:55:30 -0700 X-IronPort-AV: E=Sophos;i="5.90,281,1643702400"; d="scan'208";a="577741324" Received: from embargo.jf.intel.com ([10.165.9.183]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2022 00:55:30 -0700 From: Yang Weijiang To: pbonzini@redhat.com, jmattson@google.com, seanjc@google.com, like.xu.linux@gmail.com, vkuznets@redhat.com, wei.w.wang@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Like Xu , Peter Zijlstra , Kan Liang , Andi Kleen , Yang Weijiang Subject: [PATCH v10 04/16] perf/x86/lbr: Simplify the exposure check for the LBR_INFO registers Date: Fri, 22 Apr 2022 03:54:57 -0400 Message-Id: <20220422075509.353942-5-weijiang.yang@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220422075509.353942-1-weijiang.yang@intel.com> References: <20220422075509.353942-1-weijiang.yang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Like Xu The x86_pmu.lbr_info is 0 unless explicitly initialized, so there's no point checking x86_pmu.intel_cap.lbr_format. Cc: Peter Zijlstra Reviewed-by: Kan Liang Reviewed-by: Andi Kleen Signed-off-by: Like Xu Signed-off-by: Yang Weijiang --- arch/x86/events/intel/lbr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/events/intel/lbr.c b/arch/x86/events/intel/lbr.c index fe1742c4ca49..4529ce448b2e 100644 --- a/arch/x86/events/intel/lbr.c +++ b/arch/x86/events/intel/lbr.c @@ -1874,12 +1874,10 @@ void __init intel_pmu_arch_lbr_init(void) */ int x86_perf_get_lbr(struct x86_pmu_lbr *lbr) { - int lbr_fmt = x86_pmu.intel_cap.lbr_format; - lbr->nr = x86_pmu.lbr_nr; lbr->from = x86_pmu.lbr_from; lbr->to = x86_pmu.lbr_to; - lbr->info = (lbr_fmt == LBR_FORMAT_INFO) ? x86_pmu.lbr_info : 0; + lbr->info = x86_pmu.lbr_info; return 0; } -- 2.27.0