mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: jasowang@redhat.com, mst@redhat.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Cc: sgarzare@redhat.com, eperezma@redhat.com, lulu@redhat.com,
	tglx@linutronix.de, peterz@infradead.org, paulmck@kernel.org,
	maz@kernel.org, pasic@linux.ibm.com, cohuck@redhat.com
Subject: [PATCH V3 3/9] virtio: introduce config op to synchronize vring callbacks
Date: Mon, 25 Apr 2022 10:44:12 +0800	[thread overview]
Message-ID: <20220425024418.8415-4-jasowang@redhat.com> (raw)
In-Reply-To: <20220425024418.8415-1-jasowang@redhat.com>

This patch introduces new virtio config op to vring
callbacks. Transport specific method is required to make sure the
write before this function is visible to the vring_interrupt() that is
called after the return of this function. For the transport that
doesn't provide synchronize_vqs(), use synchornize_rcu() which
synchronize with IRQ implicitly as a fallback.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Halil Pasic <pasic@linux.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 include/linux/virtio_config.h | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
index b341dd62aa4d..14fe89ff99c7 100644
--- a/include/linux/virtio_config.h
+++ b/include/linux/virtio_config.h
@@ -57,6 +57,10 @@ struct virtio_shm_region {
  *		include a NULL entry for vqs unused by driver
  *	Returns 0 on success or error status
  * @del_vqs: free virtqueues found by find_vqs().
+ * @synchronize_cbs: synchronize with the virtqueue callbacks (optional)
+ *      Make sure the writes commited before this method is visible to
+ *      vring_interrupt() which is called after this method.
+ *      vdev: the virtio_device
  * @get_features: get the array of feature bits for this device.
  *	vdev: the virtio_device
  *	Returns the first 64 feature bits (all we currently need).
@@ -89,6 +93,7 @@ struct virtio_config_ops {
 			const char * const names[], const bool *ctx,
 			struct irq_affinity *desc);
 	void (*del_vqs)(struct virtio_device *);
+	void (*synchronize_cbs)(struct virtio_device *);
 	u64 (*get_features)(struct virtio_device *vdev);
 	int (*finalize_features)(struct virtio_device *vdev);
 	const char *(*bus_name)(struct virtio_device *vdev);
@@ -217,6 +222,25 @@ int virtio_find_vqs_ctx(struct virtio_device *vdev, unsigned nvqs,
 				      desc);
 }
 
+/**
+ * virtio_synchronize_cbs - synchronize with virtqueue callbacks
+ * @vdev: the device
+ */
+static inline
+void virtio_synchronize_cbs(struct virtio_device *dev)
+{
+	if (dev->config->synchronize_cbs) {
+		dev->config->synchronize_cbs(dev);
+	} else {
+		/*
+		 * A best effort fallback to synchronize with
+		 * interrupts, preemption and softirq. See comment
+		 * above synchronize_rcu().
+		 */
+		synchronize_rcu();
+	}
+}
+
 /**
  * virtio_device_ready - enable vq use in probe function
  * @vdev: the device
-- 
2.25.1


  parent reply	other threads:[~2022-04-25  2:45 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25  2:44 [PATCH V3 0/9] rework on the IRQ hardening of virtio Jason Wang
2022-04-25  2:44 ` [PATCH V3 1/9] virtio: use virtio_device_ready() in virtio_device_restore() Jason Wang
2022-04-28  9:07   ` Cornelia Huck
2022-04-25  2:44 ` [PATCH V3 2/9] virtio: use virtio_reset_device() when possible Jason Wang
2022-04-28  9:07   ` Cornelia Huck
2022-04-25  2:44 ` Jason Wang [this message]
2022-04-28  9:13   ` [PATCH V3 3/9] virtio: introduce config op to synchronize vring callbacks Cornelia Huck
2022-04-29  2:08     ` Jason Wang
2022-04-29  7:25       ` Cornelia Huck
2022-05-05  8:15         ` Jason Wang
2022-04-25  2:44 ` [PATCH V3 4/9] virtio-pci: implement synchronize_cbs() Jason Wang
2022-04-25  2:44 ` [PATCH V3 5/9] virtio-mmio: " Jason Wang
2022-04-25  2:44 ` [PATCH V3 6/9] virtio-ccw: " Jason Wang
2022-04-25  8:08   ` Michael S. Tsirkin
2022-04-25  8:54     ` Cornelia Huck
2022-04-25 13:59       ` Michael S. Tsirkin
2022-04-26  2:29         ` Halil Pasic
2022-04-26  3:35           ` Michael S. Tsirkin
2022-04-26  3:38             ` Michael S. Tsirkin
2022-04-26  3:42               ` Jason Wang
2022-04-26  3:53                 ` Michael S. Tsirkin
2022-04-26  3:55                   ` Michael S. Tsirkin
2022-04-26  4:07                     ` Jason Wang
2022-04-26  6:30                       ` Michael S. Tsirkin
2022-04-27  3:53                         ` Jason Wang
2022-04-27  6:28                           ` Michael S. Tsirkin
2022-04-27  6:30                           ` Michael S. Tsirkin
2022-04-27  7:57                             ` Jason Wang
2022-04-27 15:15                               ` Michael S. Tsirkin
2022-04-26 15:47                     ` Cornelia Huck
2022-04-26 16:43                       ` Michael S. Tsirkin
2022-04-27  9:27                         ` Cornelia Huck
2022-04-28  2:43                           ` Halil Pasic
2022-04-28  3:04                             ` Jason Wang
2022-04-28  5:24                               ` Michael S. Tsirkin
2022-04-28  5:51                                 ` Jason Wang
2022-04-28  5:55                                   ` Michael S. Tsirkin
2022-04-28  6:02                                     ` Jason Wang
2022-04-28  6:17                                       ` Michael S. Tsirkin
2022-04-28  7:42                                       ` Cornelia Huck
2022-04-29  2:02                                         ` Jason Wang
2022-04-28  4:12                             ` Michael S. Tsirkin
2022-04-26  2:50       ` Halil Pasic
2022-04-26  3:46         ` Jason Wang
     [not found]   ` <20220426053856.3325-1-hdanton@sina.com>
2022-04-26  5:59     ` Jason Wang
2022-04-25  2:44 ` [PATCH V3 7/9] virtio: allow to unbreak virtqueue Jason Wang
2022-04-25 12:44   ` Cornelia Huck
2022-04-25 14:04     ` Michael S. Tsirkin
2022-04-26  3:45       ` Jason Wang
2022-04-25  2:44 ` [PATCH V3 8/9] virtio: harden vring IRQ Jason Wang
2022-04-25  2:44 ` [PATCH V3 9/9] virtio: use WARN_ON() to warning illegal status value Jason Wang
2022-04-25  2:49 ` [PATCH V3 0/9] rework on the IRQ hardening of virtio Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220425024418.8415-4-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lulu@redhat.com \
    --cc=maz@kernel.org \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sgarzare@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome