From: Andrew Morton <akpm@linux-foundation.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: kernel test robot <oliver.sang@intel.com>,
Julius Hemanth Pitti <jpitti@cisco.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>, Ingo Molnar <mingo@elte.hu>,
Al Viro <viro@zeniv.linux.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org, lkp@intel.com, Eli Cohen <elic@nvidia.com>
Subject: Re: [proc/sysctl] 1dd38979b2: BUG:kernel_NULL_pointer_dereference,address
Date: Mon, 25 Apr 2022 16:34:34 -0700 [thread overview]
Message-ID: <20220425163434.5f8f47e8c301ea30c2f94a5a@linux-foundation.org> (raw)
In-Reply-To: <YmcqCVLv3HQ+Kxeq@bombadil.infradead.org>
On Mon, 25 Apr 2022 16:08:57 -0700 Luis Chamberlain <mcgrof@kernel.org> wrote:
> On Mon, Apr 25, 2022 at 02:46:07PM -0700, Andrew Morton wrote:
> > On Mon, 25 Apr 2022 12:00:21 -0700 Luis Chamberlain <mcgrof@kernel.org> wrote:
> >
> > > Andrew, can we drop this patch for now?
> >
> > I've been sitting on (ie, forgotten about) this patch
> > (https://lore.kernel.org/all/20200709235115.56954-1-jpitti@cisco.com/T/#u)
>
> Jesh, yeah I see.
>
> > for two years. Evidently waiting for you/Kees/Ingo to provide
> > guidance. So sure, the need seems very unurgent so I can drop it.
>
> Well Keew as OK with it, but I yeah I can't decipher the issue at this
> point in time.
>
> > However I fail to see how that patch could have caused this crash. I'm
> > suspecting a bisection error?
> >
> > Maybe something is unwell in drivers/vdpa/vdpa_user/vduse_dev.c.
>
> At a quick glance, yes it could very well by vduse_init() is messy and
> races somehow with init, but if a race does lurk here my instincts tell
> me this can't be the only place.
>
> Not sure if leaving a patch in place more time to see how else things
> can explode is worth it.
Confused. Are you thinking that the above-linked patch was somehow
involved in this crash? If so, but how? All it does it to permit
unprivileged reads to four ints via proc_dointvec_minmax()?
next prev parent reply other threads:[~2022-04-25 23:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 8:33 kernel test robot
2022-04-25 19:00 ` Luis Chamberlain
2022-04-25 21:46 ` Andrew Morton
2022-04-25 23:08 ` Luis Chamberlain
2022-04-25 23:34 ` Andrew Morton [this message]
2022-04-25 23:57 ` Luis Chamberlain
2022-04-26 4:24 ` Luis Chamberlain
2022-04-26 4:49 ` Yongji Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220425163434.5f8f47e8c301ea30c2f94a5a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=elic@nvidia.com \
--cc=hannes@cmpxchg.org \
--cc=jpitti@cisco.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=mcgrof@kernel.org \
--cc=mingo@elte.hu \
--cc=oliver.sang@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®