From: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
To: <rostedt@goodmis.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <mark-pk.tsai@mediatek.com>,
<matthias.bgg@gmail.com>, <mingo@redhat.com>,
<yj.chiang@mediatek.com>
Subject: [PATCH v4 0/2] tracing: make tracer_init_tracefs initcall asynchronous
Date: Tue, 26 Apr 2022 20:24:05 +0800 [thread overview]
Message-ID: <20220426122407.17042-1-mark-pk.tsai@mediatek.com> (raw)
Move trace_eval_init() to subsys_initcall to make it start
earlier.
And to avoid tracer_init_tracefs being blocked by
trace_event_sem which trace_eval_init() hold [1],
queue tracer_init_tracefs() to eval_map_wq to let
the two works being executed sequentially.
It can speed up the initialization of kernel as result
of making tracer_init_tracefs asynchronous.
On my arm64 platform, it reduce ~20ms of 125ms which total
time do_initcalls spend.
Changes in v2:
- Fix the use of ftrace_eval_maps in INIT_DATA after initmem_free().
In v1, a kthread is create for tracer_init_tracefs() which
might cause kernel crash if initmem is free before it finish.
In v2, the work of tracer_init_tracefs() is separated into 2 parts,
one is put to subsys_initcall and the other is queue to eval_map_wq
which can make sure it always finish before initmem is free.
Changes in v3:
- Avoid adding tracer option before __update_tracer_options finish to fix
the warning report by kernel test robot.
Reported-by: kernel test robot <oliver.sang@intel.com>
https://lore.kernel.org/lkml/20220322133339.GA32582@xsang-OptiPlex-9020/
Changes in v4:
- Set `tracer_options_updated = true` before calling __update_tracer_options().
Otherwise, __update_tracer_options() will skip all the tracer in trace_array.
- Init tracerfs_init_work only when eval_map_wq is successfully created.
Mark-PK Tsai (2):
tracing: Avoid adding tracer option before update_tracer_options
tracing: make tracer_init_tracefs initcall asynchronous
kernel/trace/trace.c | 39 +++++++++++++++++++++++++++++----------
1 file changed, 29 insertions(+), 10 deletions(-)
--
2.18.0
next reply other threads:[~2022-04-26 12:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 12:24 Mark-PK Tsai [this message]
2022-04-26 12:24 ` [PATCH v4 1/2] tracing: Avoid adding tracer option before update_tracer_options Mark-PK Tsai
2022-04-26 12:24 ` [PATCH v4 2/2] tracing: make tracer_init_tracefs initcall asynchronous Mark-PK Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220426122407.17042-1-mark-pk.tsai@mediatek.com \
--to=mark-pk.tsai@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=yj.chiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®