From: Andrew Morton <akpm@linux-foundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Ira Weiny <ira.weiny@intel.com>,
Catalin Marinas <catalin.marinas@arm.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Peter Collingbourne <pcc@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/highmem: VM_BUG_ON() if offset + len > PAGE_SIZE
Date: Tue, 26 Apr 2022 12:34:12 -0700 [thread overview]
Message-ID: <20220426123412.51fb58780a8fe2b32c7814ce@linux-foundation.org> (raw)
In-Reply-To: <20220426193020.8710-1-fmdefrancesco@gmail.com>
On Tue, 26 Apr 2022 21:30:20 +0200 "Fabio M. De Francesco" <fmdefrancesco@gmail.com> wrote:
> Add VM_BUG_ON() bounds checking to make sure that, if "offset + len>
> PAGE_SIZE", memset() does not corrupt data in adjacent pages.
>
hm, why? To match all the other functions in there?
I suppose that's logical. Or we could just delete all the other
VM_BUG_ON()s. Have any of them proven to be at all useful?
next prev parent reply other threads:[~2022-04-26 19:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 19:30 Fabio M. De Francesco
2022-04-26 19:34 ` Andrew Morton [this message]
2022-04-26 20:19 ` Fabio M. De Francesco
2022-04-26 20:48 ` Andrew Morton
2022-04-26 21:10 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220426123412.51fb58780a8fe2b32c7814ce@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=fmdefrancesco@gmail.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pcc@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®