From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 317B4C433F5 for ; Tue, 26 Apr 2022 15:39:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352400AbiDZPmu (ORCPT ); Tue, 26 Apr 2022 11:42:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352020AbiDZPmp (ORCPT ); Tue, 26 Apr 2022 11:42:45 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC5C1633AE for ; Tue, 26 Apr 2022 08:39:36 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id c190-20020a1c35c7000000b0038e37907b5bso1797128wma.0 for ; Tue, 26 Apr 2022 08:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cvlSVuXcRiw+6iepFL0TlfUcx282zkxl1raumY/nhds=; b=XqyHlWpjPB7Q+meLftRFxAA4/vut+Zg/jblwEOYeN2/9RrUClE1oRIa+itbJO86UsN a/n3w1u6tZNLdrTQKcX30CsQWV+uRP/bfIDP2Nzs4MMJ9O3fCY5WTKSkD5mr++zKzldA M7An9v2x8D0X+m5zpI4/PxRUTmUiS/whp8Zh45lPgfFzBciVnG3D1Eea1yphdR7qCecI OXVNjQC5tLvhjSNVWhfN9utIcUjqxlJBL7OSuxsvNDZDNhE05RZrQkTFEoLqtpsWXwmQ qwaHAihO0TV2QTholfA58F4rw/C0eOYG5IO/es/V3m7Bc854LxC7I1WKT4QRKeXFuj44 3SKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cvlSVuXcRiw+6iepFL0TlfUcx282zkxl1raumY/nhds=; b=5a5Fnv2KUwwy54D6IRnq0NTarHHbKLajhOj3INEX0ZLEKKxPHxT3u3EZe0IEzg+PKk pdrfhu4kbkddBOOyG+AnhVywNhHsjd6OwSM5JwQKIFG//qtcqfkxkTQTgS9CPxMEdOJz dgVGtYpN5OVD8F6qeJrh7GICCmc/Y0ILIYbxBsoHSoNMBmLJ757alvyVnpgFW2YI0D4K 9V1qhO4sWZiPWAYvwGHL8gIXg2VfHW6Tx3yW6HsmyDlXgwp6d2GbmI164vVg5c41o631 6loK3Iz4v5nKznV3xcEzRpTNRMqwebo6i+Jr0uJlfsQbCJ27m9100IjyY8kJR1P82eAx gzRA== X-Gm-Message-State: AOAM532FGTr6FjYhm736xY06EDBV3UJqgUFBUTmZAiFKOIK4neRZuqZQ bDr6QeJwGS3I3Yat+Itzwv3zYw== X-Google-Smtp-Source: ABdhPJywdCr6tJ5pk7SryEdp3Tc08AQNoOkOAPLmI9COo8quqNDluSbMKyvMb7C29oOOOAKqNMrH4g== X-Received: by 2002:a05:600c:3c86:b0:392:990b:ae29 with SMTP id bg6-20020a05600c3c8600b00392990bae29mr30830958wmb.105.1650987575370; Tue, 26 Apr 2022 08:39:35 -0700 (PDT) Received: from radium ([88.160.162.107]) by smtp.gmail.com with ESMTPSA id 204-20020a1c02d5000000b003928c42d02asm13873467wmc.23.2022.04.26.08.39.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 08:39:34 -0700 (PDT) Date: Tue, 26 Apr 2022 17:39:31 +0200 From: Fabien Parent To: Neil Armstrong Cc: Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Hermes Wu , Allen Chen , AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/bridge: ite-it6505: add missing Kconfig option select Message-ID: <20220426153931.suiuc7o53dt6s2es@radium> References: <20220426141536.274727-1-fparent@baylibre.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="273566twpnhexmyw" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --273566twpnhexmyw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 26, 2022 at 05:29:31PM +0200, Neil Armstrong wrote: > On 26/04/2022 16:15, Fabien Parent wrote: > > The IT6505 is using functions provided by the DRM_DP_HELPER driver. > > In order to avoid having the bridge enabled but the helper disabled, > > let's add a select in order to be sure that the DP helper functions are > > always available. > >=20 > > Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver") > > Signed-off-by: Fabien Parent > > --- > > drivers/gpu/drm/bridge/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kc= onfig > > index 007e5a282f67..2145b08f9534 100644 > > --- a/drivers/gpu/drm/bridge/Kconfig > > +++ b/drivers/gpu/drm/bridge/Kconfig > > @@ -78,6 +78,7 @@ config DRM_ITE_IT6505 > > tristate "ITE IT6505 DisplayPort bridge" > > depends on OF > > select DRM_KMS_HELPER > > + select DRM_DP_HELPER > > select EXTCON > > help > > ITE IT6505 DisplayPort bridge chip driver. >=20 > http://lore.kernel.org/r/20220403151637.15546-1-rdunlap@infradead.org als= o select DRM_DP_AUX_BUS, > can you check if this is really neaded ? Oops, I didn't notice that patch. Anyway I can successfully link with the following config: CONFIG_DRM_ITE_IT6505=3Dy CONFIG_DRM_DP_AUX_BUS=3Dm CONFIG_DRM_DP_HELPER=3Dy But I cannot with the following config: CONFIG_DRM_ITE_IT6505=3Dy CONFIG_DRM_DP_AUX_BUS=3Dm CONFIG_DRM_DP_HELPER=3Dm This suggest that DRM_DP_AUX_BUS is not required for that driver. Fabien >=20 > Neil --273566twpnhexmyw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEQyJHfU3UNW7IG61XVJKc6g3CeAAFAmJoEjIACgkQVJKc6g3C eABeHw/7Bt/VLgszCCzYH9pHOhqbs7jTipFBxg57jmdYMy+fhgNCwW6meNpvuZ5k IvAQNMY4CvdwV44bk8KWjGOKgQwu4Y5Ck30Qmy+IARf2h2VaIfmu17/viczdOmkr gbIRC99eX30uHQWRAXqyn4taRD2OR54eo7PgoqKx8AKD5rRWqlDUPUEDGXO8QE+Q RYl/DVfv1/SyZHkxuMrsYcJrWfalX7ZuSn5kVu3iOllaDL77XtbXglrc5+Udhc4b Q5JrgWsSfzQrdx7CYg+Jsg0YLfweE81QHqzztAYGzFg/v8BueApy8k4NKjqF2qTw nlUmoLTHQCyicwOrDwd+auZcurokQNAaLbiCA8hDkzd9bUNDjz/1wyG0xatxCB5W 2rL1zyHIX1S+rugza5FwDQGCUHMDaF9gkNZ2gqVM9SOsnyK5J/kYHtSGoqtb8Afw CqHLJ7qd8GinTpUIV0IpjL032Dw9rBA+CblzE4mOJx/DCuMBw9HremiI7oNJxkls P4nFXS8CEo9mrKkYtG454ADgCYAmtJOBfIspG5LpaY2Z48sy1E0jM7W6HYa8sdBt 7aq1Ly0oNT3Il3k1qZrMsQDpSzKFI3cxeFH8eaaJiZ/YYklyFCa/cuk7QGw1HoBY kgmyzgcEXck4nrxLD1ic3bcqWOg4acME1mp9UvuUB0Ify+1WOvA= =FNMT -----END PGP SIGNATURE----- --273566twpnhexmyw--