From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8729CC433F5 for ; Tue, 26 Apr 2022 19:04:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353778AbiDZTHl (ORCPT ); Tue, 26 Apr 2022 15:07:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353780AbiDZTFl (ORCPT ); Tue, 26 Apr 2022 15:05:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FA951999F2; Tue, 26 Apr 2022 12:02:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 51E77B82255; Tue, 26 Apr 2022 19:02:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECA7CC385A4; Tue, 26 Apr 2022 19:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650999749; bh=FnVPTjM3GsvuIrMku4njjNTlaunmQHwQbRF+hj+sgnQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HY3mI/ammsFNlZBLWvS4Bz0Ej6br7d3Hyc3QA5Mn398PS/Ng+8QCnlDHYvNxQqhzY N+gwef6aCq1w1d96Nm1diT19fl1P2Q82yazjVUWQslIRauAHXFN8sEyIp8W1TSBYfD zYDJNQHYcYkBLqKs6h2kZk/igajpgUHMcEAc1tEx0/QWQohOGMHlhRNKHkjEe19J3I AOryZq6cLbZe500woTGQLW7vd+LJ8B8slDKa2SC5Q98+f4sp8whTSrdaqLGQNsdJrI DgC/5c8K6vNDxgajvEAWrnMZVitM+C7s0GBQNFbhr6GoqHWx+lNVeWBNNaEJ/DKx29 IOZ4hGLxDKecw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zheyu Ma , Damien Le Moal , Sasha Levin , linux-ide@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 13/15] ata: pata_marvell: Check the 'bmdma_addr' beforing reading Date: Tue, 26 Apr 2022 15:02:12 -0400 Message-Id: <20220426190216.2351413-13-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220426190216.2351413-1-sashal@kernel.org> References: <20220426190216.2351413-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zheyu Ma [ Upstream commit aafa9f958342db36c17ac2a7f1b841032c96feb4 ] Before detecting the cable type on the dma bar, the driver should check whether the 'bmdma_addr' is zero, which means the adapter does not support DMA, otherwise we will get the following error: [ 5.146634] Bad IO access at port 0x1 (return inb(port)) [ 5.147206] WARNING: CPU: 2 PID: 303 at lib/iomap.c:44 ioread8+0x4a/0x60 [ 5.150856] RIP: 0010:ioread8+0x4a/0x60 [ 5.160238] Call Trace: [ 5.160470] [ 5.160674] marvell_cable_detect+0x6e/0xc0 [pata_marvell] [ 5.161728] ata_eh_recover+0x3520/0x6cc0 [ 5.168075] ata_do_eh+0x49/0x3c0 Signed-off-by: Zheyu Ma Signed-off-by: Damien Le Moal Signed-off-by: Sasha Levin --- drivers/ata/pata_marvell.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ata/pata_marvell.c b/drivers/ata/pata_marvell.c index 361597d14c56..d45a75bfc016 100644 --- a/drivers/ata/pata_marvell.c +++ b/drivers/ata/pata_marvell.c @@ -83,6 +83,8 @@ static int marvell_cable_detect(struct ata_port *ap) switch(ap->port_no) { case 0: + if (!ap->ioaddr.bmdma_addr) + return ATA_CBL_PATA_UNK; if (ioread8(ap->ioaddr.bmdma_addr + 1) & 1) return ATA_CBL_PATA40; return ATA_CBL_PATA80; -- 2.35.1