Re: [PATCH V1] mmc: core: Add partial initialization support

[kernel test robot <lkp@intel.com>]

Hi Srinivasarao,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on ulf-hansson-mmc-mirror/next v5.18-rc4 next-20220426]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Srinivasarao-Pathipati/mmc-core-Add-partial-initialization-support/20220426-175124
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d615b5416f8a1afeb82d13b238f8152c572d59c0
config: nios2-randconfig-m031-20220425 (https://download.01.org/0day-ci/archive/20220427/202204270458.l6hjhnD4-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

smatch warnings:
drivers/mmc/core/mmc.c:2168 _mmc_suspend() warn: inconsistent indenting

vim +2168 drivers/mmc/core/mmc.c

  2146	
  2147	static int _mmc_suspend(struct mmc_host *host, bool is_suspend)
  2148	{
  2149		int err = 0;
  2150		unsigned int notify_type = is_suspend ? EXT_CSD_POWER_OFF_SHORT :
  2151						EXT_CSD_POWER_OFF_LONG;
  2152	
  2153		mmc_claim_host(host);
  2154	
  2155		if (mmc_card_suspended(host->card))
  2156			goto out;
  2157	
  2158		err = _mmc_flush_cache(host);
  2159		if (err)
  2160			goto out;
  2161	
  2162		if (mmc_can_poweroff_notify(host->card) &&
  2163		    ((host->caps2 & MMC_CAP2_FULL_PWR_CYCLE) || !is_suspend ||
  2164		     (host->caps2 & MMC_CAP2_FULL_PWR_CYCLE_IN_SUSPEND)))
  2165			err = mmc_poweroff_notify(host->card, notify_type);
  2166		if (mmc_can_sleepawake(host)) {
  2167			memcpy(&host->cached_ios, &host->ios, sizeof(host->cached_ios));
> 2168			 mmc_cache_card_ext_csd(host);
  2169		}
  2170		if (mmc_can_sleep(host->card))
  2171			err = mmc_sleepawake(host, true);
  2172		else if (!mmc_host_is_spi(host))
  2173			err = mmc_deselect_cards(host);
  2174	
  2175		if (!err) {
  2176			mmc_power_off(host);
  2177			mmc_card_set_suspended(host->card);
  2178		}
  2179	out:
  2180		mmc_release_host(host);
  2181		return err;
  2182	}
  2183	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp