From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F3E3C433FE for ; Thu, 28 Apr 2022 09:24:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345042AbiD1JXG (ORCPT ); Thu, 28 Apr 2022 05:23:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231823AbiD1JQr (ORCPT ); Thu, 28 Apr 2022 05:16:47 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 523A55DE40 for ; Thu, 28 Apr 2022 02:13:33 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23S85oPm014938; Thu, 28 Apr 2022 04:12:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=fhO5OWNs7ldbb0025j9mY6KX+Symbg/QpoLGDSOJ+uE=; b=enTIccuO6DnllbRS7rvvcVza73OAWwSHdlFrRddxjsHM8oHoiLCvVyF86O2c5uWo10tM setgC0y2gGV9AQ3RbFBqfB/ZGI2sAoJTzfwFMK6W0HFwsw0iGZGPDRmm93ciffyhh8AT p/bmFvcamhpZqtBZWmpOpUj+H0DsdWECX1OW0M2B7JKgcAmm9fHgSiaSJXTTah5SLCMB a6xaLBUkJGFqJAqVxpUW9krzeOW4T1LU6CgkuahSFmSlY/7NBspqAhgadCjEhIT7HAW+ otd/OawR1ZwBXYuiatGBpO663Mjdh0jZlg7dysV6QBW+6UVWaVeXq+v7OqOS8frYhwKC Ew== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3fprt61w5e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 28 Apr 2022 04:12:50 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Apr 2022 10:12:48 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Thu, 28 Apr 2022 10:12:48 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 9276146C; Thu, 28 Apr 2022 09:12:48 +0000 (UTC) Date: Thu, 28 Apr 2022 09:12:48 +0000 From: Charles Keepax To: Vitaly Rodionov CC: Jaroslav Kysela , Takashi Iwai , Mark Brown , , , , Stefan Binding Subject: Re: [PATCH 20/26] ASoC: cs35l41: Add common cs35l41 enter hibernate function Message-ID: <20220428091248.GP38351@ediswmail.ad.cirrus.com> References: <20220427150720.9194-1-vitalyr@opensource.cirrus.com> <20220427150720.9194-21-vitalyr@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220427150720.9194-21-vitalyr@opensource.cirrus.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: GQdJADMGzk9gxOMYQuqQXSy4g2VGf6d1 X-Proofpoint-ORIG-GUID: GQdJADMGzk9gxOMYQuqQXSy4g2VGf6d1 X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 27, 2022 at 04:07:14PM +0100, Vitaly Rodionov wrote: > From: Stefan Binding > > Since the CS35L41 HDA driver also support hibernation, it > makes sense to move code from the ASoC driver to enter > hibernation into common code. > > Since HDA must support laptops which do not support hibernation > due to lack of external boost GPIO it is necessary to > ensure the function returns an error when an unsupported > boost type is in use. > > Signed-off-by: Stefan Binding > Signed-off-by: Vitaly Rodionov > --- Acked-by: Charles Keepax Thanks, Charles