From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] usb: core: acpi: Rely on the sysdev pointer
Date: Thu, 28 Apr 2022 14:10:54 +0300 [thread overview]
Message-ID: <20220428111056.3558-1-heikki.krogerus@linux.intel.com> (raw)
Hi,
I've added a comment in the first patch explaining that the sysdev
pointer is the host controller from firmware perspective like
requested by Andy. But please note that I did not make any comments
about the location of the sysdev ACPI companion in ACPI namespace on
purpose. We don't need to, and we actually can't make any assumptions
about that.
original cover letter:
Since we have that sysdev pointer, we need to use it also when
assigning the ACPI companion for the root hub. That should remove the
need to "manually" assign the ACPI companion to the controller device
in the xhci glue drivers like dwc3-host.c.
Assigning the ACPI companion in those glue drivers is very
problematic, because it screws up the fwnode->secondary pointer. But
as said, since we have that sysdev pointer, there is no need to
manually set it. sysdev pointer should always point to the correct
physical device from firmware PoW.
thanks,
Heikki Krogerus (2):
usb: core: acpi: Use the sysdev pointer instead of controller device
usb: dwc3: host: Stop setting the ACPI companion
drivers/usb/core/usb-acpi.c | 7 +++++--
drivers/usb/dwc3/host.c | 2 --
2 files changed, 5 insertions(+), 4 deletions(-)
--
2.35.1
next reply other threads:[~2022-04-28 11:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 11:10 Heikki Krogerus [this message]
2022-04-28 11:10 ` [PATCH v2 1/2] usb: core: acpi: Use the sysdev pointer instead of controller device Heikki Krogerus
2022-04-28 11:10 ` [PATCH v2 2/2] usb: dwc3: host: Stop setting the ACPI companion Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220428111056.3558-1-heikki.krogerus@linux.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®