From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A3FAC433EF for ; Thu, 28 Apr 2022 11:11:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345368AbiD1LO0 (ORCPT ); Thu, 28 Apr 2022 07:14:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345455AbiD1LOR (ORCPT ); Thu, 28 Apr 2022 07:14:17 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56908220CB; Thu, 28 Apr 2022 04:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651144263; x=1682680263; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RcJmmFSAKdqn8rkcY+jzES/FkuNtJTKacj4WSDA1mlk=; b=YoJAWzuC4pjd3NKINrFsYrFRa1EYDqQt05aYvMxm4vgXpUJcIY850p1h eTJ6rd0MHpE9L9ly58xb6SPQfu3z9Lh7eyMaWloR6+CzYqgQfjVFUaGDo zJ1FFN8rmaaNcWqePzCvcpNTs2EO2jEzxH91iovWE7XrUcIt7jPWdFi0A aU+H+zNVg3yfrfvJ3J3e1sCcmhvls4q7o8zZoEDKANb9evSEozvjGRXVn M3McV4dZ3Ym1adVqMPKOIaSKqB6jVGwaPEn52TAynzw8fmN/k1qRP/mBV VW/yQreI0c5tmXr94osw2wXWmUKvn0cI5q+RWqgoM+2YldWyro55yXQiZ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10330"; a="291414554" X-IronPort-AV: E=Sophos;i="5.90,295,1643702400"; d="scan'208";a="291414554" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2022 04:11:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,295,1643702400"; d="scan'208";a="706011971" Received: from black.fi.intel.com (HELO black.fi.intel.com.) ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 28 Apr 2022 04:11:00 -0700 From: Heikki Krogerus To: Greg Kroah-Hartman Cc: Felipe Balbi , "Rafael J. Wysocki" , Mathias Nyman , Andy Shevchenko , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] usb: dwc3: host: Stop setting the ACPI companion Date: Thu, 28 Apr 2022 14:10:56 +0300 Message-Id: <20220428111056.3558-3-heikki.krogerus@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220428111056.3558-1-heikki.krogerus@linux.intel.com> References: <20220428111056.3558-1-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is no longer needed. The sysdev pointer is now used when assigning the ACPI companions to the xHCI ports and USB devices. Assigning the ACPI companion here resulted in the fwnode->secondary pointer to be replaced also for the parent dwc3 device since the primary fwnode (the ACPI companion) was shared. That was unintentional and it created potential side effects like resource leaks. Signed-off-by: Heikki Krogerus --- drivers/usb/dwc3/host.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c index eda871973d6cc..f56c30cf151e4 100644 --- a/drivers/usb/dwc3/host.c +++ b/drivers/usb/dwc3/host.c @@ -7,7 +7,6 @@ * Authors: Felipe Balbi , */ -#include #include #include #include @@ -83,7 +82,6 @@ int dwc3_host_init(struct dwc3 *dwc) } xhci->dev.parent = dwc->dev; - ACPI_COMPANION_SET(&xhci->dev, ACPI_COMPANION(dwc->dev)); dwc->xhci = xhci; -- 2.35.1