From: Jianqun Xu <jay.xu@rock-chips.com>
To: kuba@kernel.org, davem@davemloft.net, joabreu@synopsys.com,
alexandre.torgue@st.com, peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Jianqun Xu <jay.xu@rock-chips.com>
Subject: [PATCH V2] ethernet: stmmac: support driver work for DTs without child queue node
Date: Fri, 29 Apr 2022 08:46:05 +0800 [thread overview]
Message-ID: <20220429004605.1010751-1-jay.xu@rock-chips.com> (raw)
In-Reply-To: <20220428010927.526310-1-jay.xu@rock-chips.com>
The driver use the value of property 'snps,rx-queues-to-use' to loop
same numbers child nodes as queues, such as:
gmac {
rx-queues-config {
snps,rx-queues-to-use = <1>;
queue0 {
// nothing need here.
};
};
};
Since a patch for dtc from rockchip will delete all node without any
properties or child node, the queue0 node will be deleted, that caused
the driver fail to probe:
rk_gmac-dwmac: probe of ffa80000.ethernet failed with error -22
This patch try to support driver work well for DTs without setting for
the child queue nodes and then have none child queue nodes.
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
---
v2:
- change subject and update commit comment, sugguested by Kicinski
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index 2d8c095f3856..4f01a41c485c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -279,7 +279,7 @@ static int stmmac_mtl_setup(struct platform_device *pdev,
queue++;
}
- if (queue != plat->tx_queues_to_use) {
+ if (queue != plat->tx_queues_to_use && of_get_child_count(tx_node)) {
ret = -EINVAL;
dev_err(&pdev->dev, "Not all TX queues were configured\n");
goto out;
--
2.25.1
next prev parent reply other threads:[~2022-04-29 0:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 1:09 [PATCH RESEND] ethernet: stmmac: fix for none child queue node for tx node Jianqun Xu
2022-04-28 22:40 ` Jakub Kicinski
2022-04-29 0:46 ` Jianqun Xu [this message]
2022-04-29 0:56 ` [PATCH V2] ethernet: stmmac: support driver work for DTs without child queue node Andrew Lunn
[not found] ` <2022042909545741446644@rock-chips.com>
2022-04-29 12:14 ` Andrew Lunn
2022-04-29 1:40 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429004605.1010751-1-jay.xu@rock-chips.com \
--to=jay.xu@rock-chips.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®