From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE460C433FE for ; Fri, 29 Apr 2022 01:04:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353702AbiD2BHs (ORCPT ); Thu, 28 Apr 2022 21:07:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353697AbiD2BHj (ORCPT ); Thu, 28 Apr 2022 21:07:39 -0400 Received: from mail-pj1-x1049.google.com (mail-pj1-x1049.google.com [IPv6:2607:f8b0:4864:20::1049]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4F49BC853 for ; Thu, 28 Apr 2022 18:04:22 -0700 (PDT) Received: by mail-pj1-x1049.google.com with SMTP id s18-20020a17090aa11200b001d92f7609e8so3317673pjp.3 for ; Thu, 28 Apr 2022 18:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=iAfBavwbsHQb7nUtWPmITw7texHIRzXx3genh74Wrm4=; b=d4B9ajRP0cdRUOdbpcrENwHCKJkDs3tQ5IHjndd9KvxYQ/7SOn0yIM78dzq5kyT1Nd M0pxUa87fybMap7EXy0g6Q2dzahdlYQCHNzaMbjOX11TvJju71dPepLRrPh53k+2YnMl EnjrGxBJnTCkDTRSvATHYreY/CvYVr9s9L56paGcBTUPU4X9uDWh+Hlb5+mlHpS4rUDe wee+clVpxgdHIJ2JqmMlMcxtR8V7kdiCEd+qCf5FFdazGj7pN34Ei0weBZaPUyQuANaO 7YRgwLB/iW0tih0KgEQOaDGGZL8NclWvsJc5EygBZTI0gnxG9sMFJFZ3dPrn9mJLosJX jS9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=iAfBavwbsHQb7nUtWPmITw7texHIRzXx3genh74Wrm4=; b=UOb+gGwXxEWF9XIESeWWbaSBryBP3fhKXzd3xf0TvbwSbfboei80u0XepL+kqH9gjN 33KuWd/QILokaYzJgSq824+CHmXfBxN4ongapVXpu6stYEeCBe9+VYRAFM6eCkLLEXFF vbWog/VtzqHkxOXh4TwSWZYogGtgxgtK1QNvPIr1z4UIVEqnY/sKrRzoKmTVotoM1t68 pX2zBikGZ8i8+u7hXExX5TNqqE01iyVJTBq4kMK/MvCX2rVgCbXc87OeGegk+hamvKoS MOGzvHqJ6NfxAo+aJXGVnepdpxLNHFltAW2Y41dGq+W0vgC/gVnXPVrJaGioHnDhgKod BBXw== X-Gm-Message-State: AOAM531m05u5pwpit+Z0y+ZSL4mRbu0vP9Wbonm1uVaASBP656t7xo+J PXKRDXhNW059tcAh6Np/qnd0wwnj30U= X-Google-Smtp-Source: ABdhPJyExsvWbr+aCzXd9ADsT+u2WdLcxHUGXGu6s7gm+EXhhn3Fb9B0jU9fQPr7QbfeFO0iu8TIXA9Sf30= X-Received: from seanjc.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:3e5]) (user=seanjc job=sendgmr) by 2002:a17:902:ce11:b0:15b:4232:e5e7 with SMTP id k17-20020a170902ce1100b0015b4232e5e7mr36162290plg.39.1651194262244; Thu, 28 Apr 2022 18:04:22 -0700 (PDT) Reply-To: Sean Christopherson Date: Fri, 29 Apr 2022 01:04:08 +0000 In-Reply-To: <20220429010416.2788472-1-seanjc@google.com> Message-Id: <20220429010416.2788472-3-seanjc@google.com> Mime-Version: 1.0 References: <20220429010416.2788472-1-seanjc@google.com> X-Mailer: git-send-email 2.36.0.464.gb9c8b46e94-goog Subject: [PATCH 02/10] KVM: Drop bogus "pfn != 0" guard from kvm_release_pfn() From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove a check from kvm_release_pfn() to bail if the provided @pfn is zero. Zero is a perfectly valid pfn on most architectures, and should not be used to indicate an error or an invalid pfn. The bogus check was added by commit 917248144db5 ("x86/kvm: Cache gfn to pfn translation"), which also did the bad thing of zeroing the pfn and gfn to mark a cache invalid. Thankfully, that bad behavior was axed by commit 357a18ad230f ("KVM: Kill kvm_map_gfn() / kvm_unmap_gfn() and gfn_to_pfn_cache"). Signed-off-by: Sean Christopherson --- virt/kvm/kvm_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 04ed4334473c..154c3dda7010 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -2723,9 +2723,6 @@ EXPORT_SYMBOL_GPL(gfn_to_page); void kvm_release_pfn(kvm_pfn_t pfn, bool dirty) { - if (pfn == 0) - return; - if (dirty) kvm_release_pfn_dirty(pfn); else -- 2.36.0.464.gb9c8b46e94-goog