From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Javier Martinez Canillas <javierm@redhat.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>
Subject: [RFC PATCH v4 02/11] drm/fb-helper: Set FBINFO_MISC_FIRMWARE flag for DRIVER_FIRMWARE fb
Date: Fri, 29 Apr 2022 10:42:44 +0200 [thread overview]
Message-ID: <20220429084253.1085911-3-javierm@redhat.com> (raw)
In-Reply-To: <20220429084253.1085911-1-javierm@redhat.com>
The DRIVER_FIRMWARE flag denotes that a DRM driver uses a framebuffer
that was initialized and provided by the system firmware for scanout.
Indicate to the fbdev subsystem that the registered framebuffer is a
FBINFO_MISC_FIRMWARE, so that it can handle accordingly. For example,
wold hot-unplug the associated device if asked to remove conflicting
framebuffers.
Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
(no changes since v1)
drivers/gpu/drm/drm_fb_helper.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index d265a73313c9..76dd11888621 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -1891,6 +1891,10 @@ __drm_fb_helper_initial_config_and_unlock(struct drm_fb_helper *fb_helper,
/* don't leak any physical addresses to userspace */
info->flags |= FBINFO_HIDE_SMEM_START;
+ /* Indicate that the framebuffer is provided by the firmware */
+ if (drm_core_check_feature(dev, DRIVER_FIRMWARE))
+ info->flags |= FBINFO_MISC_FIRMWARE;
+
/* Need to drop locks to avoid recursive deadlock in
* register_framebuffer. This is ok because the only thing left to do is
* register the fbdev emulation instance in kernel_fb_helper_list. */
--
2.35.1
next prev parent reply other threads:[~2022-04-29 8:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 8:42 [RFC PATCH v4 00/11] Fix some race between sysfb device registration and drivers probe Javier Martinez Canillas
2022-04-29 8:42 ` [RFC PATCH v4 01/11] drm: Add a capability flag for simple framebuffer drivers Javier Martinez Canillas
2022-04-29 8:42 ` Javier Martinez Canillas [this message]
2022-04-29 9:14 ` [RFC PATCH v4 02/11] drm/fb-helper: Set FBINFO_MISC_FIRMWARE flag for DRIVER_FIRMWARE fb Thomas Zimmermann
2022-04-29 9:23 ` Javier Martinez Canillas
2022-04-29 10:20 ` Thomas Zimmermann
2022-04-29 10:50 ` Javier Martinez Canillas
2022-04-29 8:42 ` [RFC PATCH v4 03/11] drm/simpledrm: Set the DRM_FIRMWARE capability Javier Martinez Canillas
2022-04-29 8:42 ` [RFC PATCH v4 04/11] firmware: sysfb: Make sysfb_create_simplefb() return a pdev pointer Javier Martinez Canillas
2022-04-29 8:42 ` [RFC PATCH v4 05/11] firmware: sysfb: Add helpers to unregister a pdev and disable registration Javier Martinez Canillas
2022-04-29 8:42 ` [RFC PATCH v4 06/11] fbdev: Restart conflicting fb removal loop when unregistering devices Javier Martinez Canillas
2022-04-29 8:42 ` [RFC PATCH v4 07/11] fbdev: Make sysfb to unregister its own registered devices Javier Martinez Canillas
2022-04-29 8:42 ` [RFC PATCH v4 08/11] fbdev: Fix race between sysfb and framebuffer devices registration Javier Martinez Canillas
2022-04-29 8:42 ` [RFC PATCH v4 09/11] drm: Fix race between sysfb and DRM " Javier Martinez Canillas
2022-04-29 8:42 ` [RFC PATCH v4 10/11] Revert "fbdev: Prevent probing generic drivers if a FB is already registered" Javier Martinez Canillas
2022-04-29 8:42 ` [RFC PATCH v4 11/11] fbdev: Make registered_fb[] private to fbmem.c Javier Martinez Canillas
2022-04-29 15:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429084253.1085911-3-javierm@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®