From: Qais Yousef <qais.yousef@arm.com>
To: "Peter Zijlstra (Intel)" <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Steven Rostedt <rostedt@goodmis.org>,
Phil Auld <pauld@redhat.com>,
Giovanni Gherdovich <ggherdovich@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] sched/fair: Remove cfs_rq_tg_path()
Date: Fri, 29 Apr 2022 09:53:08 +0100 [thread overview]
Message-ID: <20220429085308.sxj2w6i3n2btbpyh@wubuntu> (raw)
In-Reply-To: <20220428144338.479094-3-qais.yousef@arm.com>
+CC lkml
On 04/28/22 15:43, Qais Yousef wrote:
> From: Dietmar Eggemann <dietmar.eggemann@arm.com>
>
> cfs_rq_tg_path() is used by a tracepoint-to traceevent (tp-2-te)
> converter to format the path of a taskgroup or autogroup respectively.
> It doesn't have any in-kernel users after the removal of the
> sched_trace_cfs_rq_path() helper function.
>
> cfs_rq_tg_path() can be coded in a tp-2-te converter.
>
> Remove it from kernel/sched/fair.c.
>
> Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Signed-off-by: Qais Yousef <qais.yousef@arm.com>
> ---
> kernel/sched/fair.c | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index ff1177a4a286..7487737c1275 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -313,19 +313,6 @@ const struct sched_class fair_sched_class;
> #define for_each_sched_entity(se) \
> for (; se; se = se->parent)
>
> -static inline void cfs_rq_tg_path(struct cfs_rq *cfs_rq, char *path, int len)
> -{
> - if (!path)
> - return;
> -
> - if (cfs_rq && task_group_is_autogroup(cfs_rq->tg))
> - autogroup_path(cfs_rq->tg, path, len);
> - else if (cfs_rq && cfs_rq->tg->css.cgroup)
> - cgroup_path(cfs_rq->tg->css.cgroup, path, len);
> - else
> - strlcpy(path, "(null)", len);
> -}
> -
> static inline bool list_add_leaf_cfs_rq(struct cfs_rq *cfs_rq)
> {
> struct rq *rq = rq_of(cfs_rq);
> @@ -493,12 +480,6 @@ static int se_is_idle(struct sched_entity *se)
> #define for_each_sched_entity(se) \
> for (; se; se = NULL)
>
> -static inline void cfs_rq_tg_path(struct cfs_rq *cfs_rq, char *path, int len)
> -{
> - if (path)
> - strlcpy(path, "(null)", len);
> -}
> -
> static inline bool list_add_leaf_cfs_rq(struct cfs_rq *cfs_rq)
> {
> return true;
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-04-29 8:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220428144338.479094-1-qais.yousef@arm.com>
2022-04-29 8:52 ` [PATCH 0/2] Remove sched_trace_*() helper functions Qais Yousef
[not found] ` <20220428144338.479094-3-qais.yousef@arm.com>
2022-04-29 8:53 ` Qais Yousef [this message]
2022-04-29 20:35 ` [tip: sched/core] sched/fair: Remove cfs_rq_tg_path() tip-bot2 for Dietmar Eggemann
[not found] ` <20220428144338.479094-2-qais.yousef@arm.com>
2022-04-29 8:52 ` [PATCH 1/2] sched/fair: Remove sched_trace_*() helper functions Qais Yousef
2022-04-29 20:35 ` [tip: sched/core] " tip-bot2 for Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429085308.sxj2w6i3n2btbpyh@wubuntu \
--to=qais.yousef@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=ggherdovich@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®