From: Martin Kaiser <martin@kaiser.cx>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH 7/9] staging: r8188eu: use ieee80211_mgmt for action category
Date: Mon, 2 May 2022 22:06:50 +0200 [thread overview]
Message-ID: <20220502200652.143665-8-martin@kaiser.cx> (raw)
In-Reply-To: <20220502200652.143665-1-martin@kaiser.cx>
Use the struct ieee80211_mgmt from ieee80211.h to read the action
category. There's no need to parse the incoming frame ourselves.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 0df89bbdb63a..96b0da90c2ba 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -3871,15 +3871,9 @@ unsigned int OnAction_p2p(struct adapter *padapter, struct recv_frame *precv_fra
unsigned int OnAction(struct adapter *padapter, struct recv_frame *precv_frame)
{
- unsigned char category;
- unsigned char *frame_body;
- u8 *pframe = precv_frame->rx_data;
-
- frame_body = (unsigned char *)(pframe + sizeof(struct ieee80211_hdr_3addr));
-
- category = frame_body[0];
+ struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)precv_frame->rx_data;
- switch (category) {
+ switch (mgmt->u.action.category) {
case RTW_WLAN_CATEGORY_BACK:
OnAction_back(padapter, precv_frame);
break;
--
2.30.2
next prev parent reply other threads:[~2022-05-02 20:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 20:06 [PATCH 0/9] staging: r8188eu: clean up OnAction Martin Kaiser
2022-05-02 20:06 ` [PATCH 1/9] staging: r8188eu: action category ht is not used Martin Kaiser
2022-05-02 20:06 ` [PATCH 2/9] staging: r8188eu: action category wmm " Martin Kaiser
2022-05-02 20:06 ` [PATCH 3/9] staging: r8188eu: remove unused action handler prototypes Martin Kaiser
2022-05-02 20:06 ` [PATCH 4/9] staging: r8188eu: remove action_handler string Martin Kaiser
2022-05-02 20:06 ` [PATCH 5/9] staging: r8188eu: remove an unused category define Martin Kaiser
2022-05-02 20:06 ` [PATCH 6/9] staging: r8188eu: replace OnAction_tbl with switch-case Martin Kaiser
2022-05-02 20:06 ` Martin Kaiser [this message]
2022-05-02 20:06 ` [PATCH 8/9] staging: r8188eu: use standard category defines Martin Kaiser
2022-05-02 20:06 ` [PATCH 9/9] staging: r8188eu: remove unused IEEE_* defines Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220502200652.143665-8-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®