From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
<linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: [PATCH v2 04/23] dt-bindings: ata: sata: Extend number of SATA ports
Date: Tue, 3 May 2022 23:09:19 +0300 [thread overview]
Message-ID: <20220503200938.18027-5-Sergey.Semin@baikalelectronics.ru> (raw)
In-Reply-To: <20220503200938.18027-1-Sergey.Semin@baikalelectronics.ru>
The denoted in the description upper limit only concerns the Port
Multipliers, but not the actual SATA ports. It's an external device
attached to a SATA port in order to access more than one SATA-drive. So
when it's attached to a SATA port it just extends the port capability
while the number of actual SATA ports stays the same. For instance on AHCI
controllers the number of actual ports is determined by the CAP.NP field
and the PI (Ports Implemented) register. AFAICS in general the maximum
number of SATA ports depends on the particular controller implementation.
Generic AHCI controller can't have more than 32 ports (since CAP.NP is of
5 bits wide and PI register is 32-bits size), while DWC AHCI SATA
controller can't be configured with more than 8 ports activated. So let's
discard the SATA ports reg-property restrictions and just make sure that
it consists of a single reg-item.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
Changelog v2:
- Add comma and replace "channel" with "SATA port" in the reg property
description (@Damien).
---
Documentation/devicetree/bindings/ata/sata-common.yaml | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/ata/sata-common.yaml b/Documentation/devicetree/bindings/ata/sata-common.yaml
index 7ac77b1c5850..9c9c621761ca 100644
--- a/Documentation/devicetree/bindings/ata/sata-common.yaml
+++ b/Documentation/devicetree/bindings/ata/sata-common.yaml
@@ -41,11 +41,10 @@ patternProperties:
properties:
reg:
minimum: 0
- maximum: 14
description:
- The ID number of the drive port SATA can potentially use a port
- multiplier making it possible to connect up to 15 disks to a single
- SATA port.
+ The ID number of the SATA port. Aside with being directly used,
+ each port can have a Port Multiplier attached thus allowing to
+ access more than one drive by means of a single SATA port.
additionalProperties: true
--
2.35.1
next prev parent reply other threads:[~2022-05-03 20:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 20:09 [PATCH v2 00/23] ata: ahci: Add DWC/Baikal-T1 AHCI SATA support Serge Semin
2022-05-03 20:09 ` [PATCH v2 01/23] dt-bindings: ata: ahci-platform: Drop dma-coherent property declaration Serge Semin
2022-05-03 20:09 ` [PATCH v2 02/23] dt-bindings: ata: ahci-platform: Detach common AHCI bindings Serge Semin
2022-05-03 20:29 ` Damien Le Moal
2022-05-03 20:43 ` Serge Semin
2022-05-03 20:09 ` [PATCH v2 03/23] dt-bindings: ata: ahci-platform: Clarify common AHCI props constraints Serge Semin
2022-05-03 20:09 ` Serge Semin [this message]
2022-05-03 20:09 ` [PATCH v2 05/23] ata: libahci_platform: Explicitly set rc on devres_alloc failure Serge Semin
2022-05-03 20:09 ` [PATCH v2 06/23] ata: libahci_platform: Convert to using platform devm-ioremap methods Serge Semin
2022-05-03 20:09 ` [PATCH v2 07/23] ata: libahci_platform: Convert to using devm bulk clocks API Serge Semin
2022-05-04 4:16 ` kernel test robot
2022-05-04 4:26 ` kernel test robot
2022-05-03 20:09 ` [PATCH v2 08/23] ata: libahci_platform: Add function returning a clock-handle by id Serge Semin
2022-05-03 20:09 ` [PATCH v2 09/23] ata: libahci_platform: Sanity check the DT child nodes number Serge Semin
2022-05-03 20:09 ` [PATCH v2 10/23] ata: libahci_platform: Parse ports-implemented property in resources getter Serge Semin
2022-05-03 20:09 ` [PATCH v2 11/23] ata: libahci_platform: Introduce reset assertion/deassertion methods Serge Semin
2022-05-03 20:09 ` [PATCH v2 12/23] dt-bindings: ata: ahci: Add platform capability properties Serge Semin
2022-05-03 20:09 ` [PATCH v2 13/23] ata: libahci: Extend port-cmd flags set with port capabilities Serge Semin
2022-05-03 20:09 ` [PATCH v2 14/23] ata: libahci: Discard redundant force_port_map parameter Serge Semin
2022-05-03 20:09 ` [PATCH v2 15/23] ata: libahci: Don't read AHCI version twice in the save-config method Serge Semin
2022-05-03 20:09 ` [PATCH v2 16/23] ata: ahci: Convert __ahci_port_base to accepting hpriv as arguments Serge Semin
2022-05-03 20:09 ` [PATCH v2 17/23] ata: ahci: Introduce firmware-specific caps initialization Serge Semin
2022-05-03 20:09 ` [PATCH v2 18/23] dt-bindings: ata: ahci: Add DWC AHCI SATA controller DT schema Serge Semin
2022-05-03 20:09 ` [PATCH v2 19/23] ata: ahci: Add DWC AHCI SATA controller support Serge Semin
2022-05-03 20:09 ` [PATCH v2 20/23] dt-bindings: ata: ahci: Add Baikal-T1 AHCI SATA controller DT schema Serge Semin
2022-05-03 20:09 ` [PATCH v2 21/23] ata: ahci-dwc: Add platform-specific quirks support Serge Semin
2022-05-03 20:09 ` [PATCH v2 22/23] ata: ahci-dwc: Add Baikal-T1 AHCI SATA interface support Serge Semin
2022-05-03 20:09 ` [PATCH v2 23/23] MAINTAINERS: Add maintainers for DWC AHCI SATA driver Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220503200938.18027-5-Sergey.Semin@baikalelectronics.ru \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=hdegoede@redhat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®