From: Frederic Weisbecker <frederic@kernel.org>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: "Paul E . McKenney" <paulmck@kernel.org>,
Neeraj Upadhyay <quic_neeraju@quicinc.com>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu/nocb: Delete local variable 'need_rcu_nocb_mask' in rcu_init_nohz()
Date: Tue, 3 May 2022 23:00:19 +0200 [thread overview]
Message-ID: <20220503210019.GB2801234@lothringen> (raw)
In-Reply-To: <20220426073626.967-1-thunder.leizhen@huawei.com>
On Tue, Apr 26, 2022 at 03:36:26PM +0800, Zhen Lei wrote:
> The local variable 'need_rcu_nocb_mask' is true only if CONFIG_NO_HZ_FULL
> is defined. So branch "if (need_rcu_nocb_mask)" can be moved within the
> scope of "#if defined(CONFIG_NO_HZ_FULL)". At this point, using variable
> 'need_rcu_nocb_mask' is not necessary, so delete it.
>
> No functional changes, but the code looks a little more concise.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> kernel/rcu/tree_nocb.h | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h
> index 636d0546a4e932e..1e334e217f0afb7 100644
> --- a/kernel/rcu/tree_nocb.h
> +++ b/kernel/rcu/tree_nocb.h
> @@ -1165,15 +1165,10 @@ EXPORT_SYMBOL_GPL(rcu_nocb_cpu_offload);
> void __init rcu_init_nohz(void)
> {
> int cpu;
> - bool need_rcu_nocb_mask = false;
> struct rcu_data *rdp;
>
> #if defined(CONFIG_NO_HZ_FULL)
> - if (tick_nohz_full_running && !cpumask_empty(tick_nohz_full_mask))
> - need_rcu_nocb_mask = true;
> -#endif /* #if defined(CONFIG_NO_HZ_FULL) */
> -
> - if (need_rcu_nocb_mask) {
> + if (tick_nohz_full_running && !cpumask_empty(tick_nohz_full_mask)) {
Thanks! I suspect though that the introduction of
CONFIG_RCU_NOCB_CPU_DEFAULT_ALL has made this patch unecessary.
> if (!cpumask_available(rcu_nocb_mask)) {
> if (!zalloc_cpumask_var(&rcu_nocb_mask, GFP_KERNEL)) {
> pr_info("rcu_nocb_mask allocation failed, callback offloading disabled.\n");
> @@ -1182,6 +1177,7 @@ void __init rcu_init_nohz(void)
> }
> rcu_nocb_is_setup = true;
> }
> +#endif /* #if defined(CONFIG_NO_HZ_FULL) */
>
> if (!rcu_nocb_is_setup)
> return;
> --
> 2.26.0.106.g9fadedd
>
next prev parent reply other threads:[~2022-05-03 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 7:36 Zhen Lei
2022-05-03 21:00 ` Frederic Weisbecker [this message]
2022-05-13 15:05 ` Paul E. McKenney
2022-05-16 1:29 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220503210019.GB2801234@lothringen \
--to=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=quic_neeraju@quicinc.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®