mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Liam Howlett <liam.howlett@oracle.com>
To: "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v9 12/69] mm/mmap: use the maple tree for find_vma_prev() instead of the rbtree
Date: Wed, 4 May 2022 01:07:53 +0000	[thread overview]
Message-ID: <20220504010716.661115-14-Liam.Howlett@oracle.com> (raw)
In-Reply-To: <20220504010716.661115-1-Liam.Howlett@oracle.com>

From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>

Use the maple tree's advanced API and a maple state to walk the tree for
the entry at the address of the next vma, then use the maple state to walk
back one entry to find the previous entry.

Add kernel documentation comments for this API.

Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
---
 mm/mmap.c | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index f582478c83b1..7ab07c67da71 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -2489,23 +2489,30 @@ struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
 }
 EXPORT_SYMBOL(find_vma);
 
-/*
- * Same as find_vma, but also return a pointer to the previous VMA in *pprev.
+/**
+ * find_vma_prev() - Find the VMA for a given address, or the next vma and
+ * set %pprev to the previous VMA, if any.
+ * @mm: The mm_struct to check
+ * @addr: The address
+ * @pprev: The pointer to set to the previous VMA
+ *
+ * Note that RCU lock is missing here since the external mmap_lock() is used
+ * instead.
+ *
+ * Returns: The VMA associated with @addr, or the next vma.
+ * May return %NULL in the case of no vma at addr or above.
  */
 struct vm_area_struct *
 find_vma_prev(struct mm_struct *mm, unsigned long addr,
 			struct vm_area_struct **pprev)
 {
 	struct vm_area_struct *vma;
+	MA_STATE(mas, &mm->mm_mt, addr, addr);
 
-	vma = find_vma(mm, addr);
-	if (vma) {
-		*pprev = vma->vm_prev;
-	} else {
-		struct rb_node *rb_node = rb_last(&mm->mm_rb);
-
-		*pprev = rb_node ? rb_entry(rb_node, struct vm_area_struct, vm_rb) : NULL;
-	}
+	vma = mas_walk(&mas);
+	*pprev = mas_prev(&mas, 0);
+	if (!vma)
+		vma = mas_next(&mas, ULONG_MAX);
 	return vma;
 }
 
-- 
2.35.1

  parent reply	other threads:[~2022-05-04  1:08 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04  1:07 [PATCH v9 00/69] Maple Tree v9 Liam Howlett
2022-05-04  1:07 ` Liam Howlett
2022-05-04  1:07 ` [PATCH v9 02/69] radix tree test suite: add pr_err define Liam Howlett
2022-05-04  1:07 ` [PATCH v9 01/69] Maple Tree: add new data structure Liam Howlett
2022-05-04  1:07 ` [PATCH v9 03/69] radix tree test suite: add kmem_cache_set_non_kernel() Liam Howlett
2022-05-04  1:07 ` [PATCH v9 04/69] radix tree test suite: add allocation counts and size to kmem_cache Liam Howlett
2022-05-04  1:07 ` [PATCH v9 05/69] radix tree test suite: add support for slab bulk APIs Liam Howlett
2022-05-04  1:07 ` [PATCH v9 06/69] radix tree test suite: add lockdep_is_held to header Liam Howlett
2022-05-04  1:07 ` [PATCH v9 07/69] lib/test_maple_tree: add testing for maple tree Liam Howlett
2022-05-04  1:07 ` [PATCH v9 08/69] mm: start tracking VMAs with " Liam Howlett
2022-05-10 10:37   ` SeongJae Park
2022-05-10 15:51     ` Liam Howlett
2022-05-10 16:58       ` Liam Howlett
2022-05-12 17:01   ` Qian Cai
2022-05-12 17:50     ` Liam Howlett
2022-06-06 12:26   ` Qian Cai
2022-06-06 16:16     ` Liam Howlett
2022-06-06 16:42       ` Qian Cai
2022-05-04  1:07 ` [PATCH v9 09/69] mm: add VMA iterator Liam Howlett
2022-05-04  1:07 ` [PATCH v9 10/69] mmap: use the VMA iterator in count_vma_pages_range() Liam Howlett
2022-05-04  1:07 ` [PATCH v9 13/69] mm/mmap: use maple tree for unmapped_area{_topdown} Liam Howlett
2022-05-04  1:07 ` Liam Howlett [this message]
2022-05-04  1:07 ` [PATCH v9 11/69] mm/mmap: use the maple tree in find_vma() instead of the rbtree Liam Howlett
2022-05-04  1:07 ` [PATCH v9 14/69] kernel/fork: use maple tree for dup_mmap() during forking Liam Howlett
2022-05-06  2:25 ` [PATCH v9 00/69] Maple Tree v9 Andrew Morton
2022-05-09 18:55   ` Liam Howlett
2022-05-09 20:02     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220504010716.661115-14-Liam.Howlett@oracle.com \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®