From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64483C433EF for ; Wed, 4 May 2022 03:28:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244552AbiEDDbc (ORCPT ); Tue, 3 May 2022 23:31:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344411AbiEDDao (ORCPT ); Tue, 3 May 2022 23:30:44 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87C762980D for ; Tue, 3 May 2022 20:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651634777; x=1683170777; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=70wCwFFYJ1c3kSyutV0+R5VqBjClLpK77FnSrlqf7n0=; b=PEOV3rjM44XrHIVH0i1vDUvAt+f5oVpxdknquJ0iBX8Du6hryKhUcXzN rZdAYfjFj2E2+bvTqttBcV/+zXB9ffCkgrD45TiZkcfC9mo0jS7QaLFYM uSBbWtyOIoUTeVfdkEvHwqLvFhxCs4De95+8ILcg0RUEGkEZmzipl9YEu rlmy+fLn7uBbkHUV0cF23BdqCAU0heT3YkbHEPtN1W/HKr4u0bF3VGw8a 9yU8uiT2+E+7FvigWJ3wrwMeljvRUaPb7fX6Eq6A4irjt0A9cVGHjkuko UjjT3p/pqcCiYSxKLuGXXG/zZJLNGM1Xfiv/2WLxuvFHqHnCura1NzdjN A==; X-IronPort-AV: E=McAfee;i="6400,9594,10336"; a="267531910" X-IronPort-AV: E=Sophos;i="5.91,196,1647327600"; d="scan'208";a="267531910" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2022 20:25:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,196,1647327600"; d="scan'208";a="693091564" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by orsmga004.jf.intel.com with ESMTP; 03 May 2022 20:25:36 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1nm5dv-000B1m-Ps; Wed, 04 May 2022 03:25:35 +0000 Date: Wed, 4 May 2022 11:24:37 +0800 From: kernel test robot To: Minchan Kim , Andrew Morton Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , LKML , Suren Baghdasaryan , Michal Hocko , John Dias , Tim Murray , Minchan Kim Subject: Re: [PATCH] mm: don't be stuck to rmap lock on reclaim path Message-ID: <202205041158.b7On1pwy-lkp@intel.com> References: <20220503170341.1413961-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220503170341.1413961-1-minchan@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Minchan, I love your patch! Yet something to improve: [auto build test ERROR on hnaz-mm/master] url: https://github.com/intel-lab-lkp/linux/commits/Minchan-Kim/mm-don-t-be-stuck-to-rmap-lock-on-reclaim-path/20220504-010625 base: https://github.com/hnaz/linux-mm master config: x86_64-randconfig-a016 (https://download.01.org/0day-ci/archive/20220504/202205041158.b7On1pwy-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 363b3a645a1e30011cc8da624f13dac5fd915628) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/0e190ce022ef259d63eb2cf50110b292ba17c79c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Minchan-Kim/mm-don-t-be-stuck-to-rmap-lock-on-reclaim-path/20220504-010625 git checkout 0e190ce022ef259d63eb2cf50110b292ba17c79c # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> mm/page_idle.c:106:19: error: passing 'const struct rmap_walk_control *' to parameter of type 'struct rmap_walk_control *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] rmap_walk(folio, &rwc); ^~~~ include/linux/rmap.h:403:63: note: passing argument to parameter 'rwc' here void rmap_walk(struct folio *folio, struct rmap_walk_control *rwc); ^ 1 error generated. vim +106 mm/page_idle.c 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 85 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 86 static void page_idle_clear_pte_refs(struct page *page) 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 87 { 4aed23a2f8aaaa Matthew Wilcox (Oracle 2022-01-29 88) struct folio *folio = page_folio(page); 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 89 /* 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 90 * Since rwc.arg is unused, rwc is effectively immutable, so we 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 91 * can make it static const to save some cycles and stack. 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 92 */ 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 93 static const struct rmap_walk_control rwc = { 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 94 .rmap_one = page_idle_clear_pte_refs_one, 2f031c6f042cb8 Matthew Wilcox (Oracle 2022-01-29 95) .anon_lock = folio_lock_anon_vma_read, 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 96 }; 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 97 bool need_lock; 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 98 4aed23a2f8aaaa Matthew Wilcox (Oracle 2022-01-29 99) if (!folio_mapped(folio) || !folio_raw_mapping(folio)) 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 100 return; 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 101 4aed23a2f8aaaa Matthew Wilcox (Oracle 2022-01-29 102) need_lock = !folio_test_anon(folio) || folio_test_ksm(folio); 4aed23a2f8aaaa Matthew Wilcox (Oracle 2022-01-29 103) if (need_lock && !folio_trylock(folio)) 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 104 return; 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 105 84fbbe21894bb9 Matthew Wilcox (Oracle 2022-01-29 @106) rmap_walk(folio, &rwc); 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 107 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 108 if (need_lock) 4aed23a2f8aaaa Matthew Wilcox (Oracle 2022-01-29 109) folio_unlock(folio); 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 110 } 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 111 -- 0-DAY CI Kernel Test Service https://01.org/lkp