mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wyes Karny <wyes.karny@amd.com>
To: <linux-kernel@vger.kernel.org>
Cc: <Lewis.Carroll@amd.com>, <Mario.Limonciello@amd.com>,
	<gautham.shenoy@amd.com>, <Ananth.Narayan@amd.com>,
	<bharata@amd.com>, <len.brown@intel.com>, <x86@kernel.org>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>, <hpa@zytor.com>,
	<peterz@infradead.org>, <chang.seok.bae@intel.com>,
	<keescook@chromium.org>, <metze@samba.org>,
	<zhengqi.arch@bytedance.com>, <mark.rutland@arm.com>,
	<puwen@hygon.cn>, <rafael.j.wysocki@intel.com>,
	<andrew.cooper3@citrix.com>, <jing2.liu@intel.com>,
	<jmattson@google.com>, <pawan.kumar.gupta@linux.intel.com>
Subject: [PATCH v2 1/3] x86: Use HALT in default_idle when idle=nomwait cmdline arg is passed
Date: Thu, 5 May 2022 16:18:54 +0530	[thread overview]
Message-ID: <20220505104856.452311-2-wyes.karny@amd.com> (raw)
In-Reply-To: <20220505104856.452311-1-wyes.karny@amd.com>

When kernel is booted with idle=nomwait avoid selecting MWAIT
as the  default idle state.

If the user boots the kernel with idle=nomwait, it is a clear
indication that they do not prefer the use of mwait as the default
idle state.  However, the current code does not take this into
consideration while selecting the default idle state on x86.

This patch fixes it by checking for the idle=nomwait boot option in
prefer_mwait_c1_over_halt().

Signed-off-by: Wyes Karny <wyes.karny@amd.com>
---
Maintainers,
 Should this be marked to stable ?

 arch/x86/kernel/process.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index b370767f5b19..49b915d1b7b4 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -824,6 +824,10 @@ static void amd_e400_idle(void)
  */
 static int prefer_mwait_c1_over_halt(const struct cpuinfo_x86 *c)
 {
+	/* User has disallowed the use of MWAIT. Fallback to HALT */
+	if (boot_option_idle_override == IDLE_NOMWAIT)
+		return 0;
+
 	if (c->x86_vendor != X86_VENDOR_INTEL)
 		return 0;
 
-- 
2.27.0


  reply	other threads:[~2022-05-05 10:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05 10:48 [PATCH v2 0/3] x86: Prefer MWAIT over HALT on AMD processors Wyes Karny
2022-05-05 10:48 ` Wyes Karny [this message]
2022-05-05 17:13   ` [PATCH v2 1/3] x86: Use HALT in default_idle when idle=nomwait cmdline arg is passed Dave Hansen
2022-05-06 11:23     ` Wyes Karny
2022-05-05 11:01 ` [PATCH v2 2/3] x86: Remove vendor checks from prefer_mwait_c1_over_halt Wyes Karny
2022-05-05 17:04   ` Dave Hansen
2022-05-06  9:42     ` Wyes Karny
2022-05-06 15:52       ` Dave Hansen
2022-05-06 18:19         ` Wyes Karny
2022-05-05 11:04 ` [PATCH v2 3/3] x86: Fix comment for X86_FEATURE_ZEN Wyes Karny
2022-05-05 17:10   ` Dave Hansen
2022-05-05 18:55     ` Wyes Karny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220505104856.452311-2-wyes.karny@amd.com \
    --to=wyes.karny@amd.com \
    --cc=Ananth.Narayan@amd.com \
    --cc=Lewis.Carroll@amd.com \
    --cc=Mario.Limonciello@amd.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=bharata@amd.com \
    --cc=bp@alien8.de \
    --cc=chang.seok.bae@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=gautham.shenoy@amd.com \
    --cc=hpa@zytor.com \
    --cc=jing2.liu@intel.com \
    --cc=jmattson@google.com \
    --cc=keescook@chromium.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=metze@samba.org \
    --cc=mingo@redhat.com \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=puwen@hygon.cn \
    --cc=rafael.j.wysocki@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=zhengqi.arch@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®