From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C32C433EF for ; Thu, 5 May 2022 11:50:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230463AbiEELyJ (ORCPT ); Thu, 5 May 2022 07:54:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236235AbiEELyB (ORCPT ); Thu, 5 May 2022 07:54:01 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6C8521A8; Thu, 5 May 2022 04:50:18 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C4AA91F8D2; Thu, 5 May 2022 11:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651751416; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SFH/x2L4G69sbr6PPcrJ24GF6EKzycaRm+AGvFywOyg=; b=Hi7oi4+HvgHIFy7zdrmmaaXxpCzxgIsU/9DIcQEQIsZBrzEnC99VBYyTdl9tCC5Clj0fNo S4wfHAcq5GS0FxgqjHIneVl1e76wHk0FgPIrmw1/VLSR1LTsnu6LUe2oRBxPFHVVShOMzR bOw8YBZW592ZS2VzcJD/HrayK6QgMM8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6974213A65; Thu, 5 May 2022 11:50:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lOXYGPi5c2IDbwAAMHmgww (envelope-from ); Thu, 05 May 2022 11:50:16 +0000 Date: Thu, 5 May 2022 13:50:15 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: "T.J. Mercier" Cc: Tejun Heo , Zefan Li , Johannes Weiner , Daniel Vetter , Hridya Valsaraju , Christian =?iso-8859-1?Q?K=F6nig?= , John Stultz , Todd Kjos , Carlos Llamas , Suren Baghdasaryan , Kalesh Singh , Kenny.Ho@amd.com, Shuah Khan , kernel-team@android.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v6 2/6] cgroup: gpu: Add a cgroup controller for allocator attribution of GPU memory Message-ID: <20220505115015.GD10890@blackbody.suse.cz> References: <20220502231944.3891435-1-tjmercier@google.com> <20220502231944.3891435-3-tjmercier@google.com> <20220504122558.GB24172@blackbody.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 04, 2022 at 10:19:20AM -0700, "T.J. Mercier" wrote: > Should I export these now for this series? Hehe, _I_ don't know. Depends on the likelihood this lands in and is built upon. > No, except maybe the gpucg_bucket name which I can add an accessor > function for. Won't this mean depending on LTO for potential inlining > of the functions currently implemented in the header? Yes. Also depends how much inlining here would be performance relevant. I suggested this with an OS vendor hat on, i.e. the less such ABI, the simpler. > I'm happy to make this change, but I wonder why some parts of the > kernel take this approach and others do not. I think there is no convention (see also Documentation/process/stable-api-nonsense.rst ;-)). Regards, Michal