From: Puyou Lu <puyou.lu@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Puyou Lu <puyou.lu@gmail.com>, Andy Shevchenko <andy@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>, Petr Mladek <pmladek@suse.com>,
Linus Walleij <linus.walleij@linaro.org>,
Guenter Roeck <linux@roeck-us.net>,
Chris Down <chris@chrisdown.name>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2] lib/string_helpers: fix not adding strarray to device's resource list.
Date: Fri, 6 May 2022 15:36:22 +0800 [thread overview]
Message-ID: <20220506073623.2679-1-puyou.lu@gmail.com> (raw)
Add allocated strarray to device's resource list. This is a must to
automatically release strarray when the device disappears.
Fixes: acdb89b6c87a ("lib/string_helpers: Introduce managed variant of kasprintf_strarray()")
Signed-off-by: Puyou Lu <puyou.lu@gmail.com>
---
Change since v1:
also set 'n' of strarray https://lore.kernel.org/lkml/20220506022845.26750-1-puyou.lu@gmail.com/
---
lib/string_helpers.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/string_helpers.c b/lib/string_helpers.c
index 4f877e9551d5..5ed3beb066e6 100644
--- a/lib/string_helpers.c
+++ b/lib/string_helpers.c
@@ -757,6 +757,9 @@ char **devm_kasprintf_strarray(struct device *dev, const char *prefix, size_t n)
return ERR_PTR(-ENOMEM);
}
+ ptr->n = n;
+ devres_add(dev, ptr);
+
return ptr->array;
}
EXPORT_SYMBOL_GPL(devm_kasprintf_strarray);
--
2.17.1
next reply other threads:[~2022-05-06 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 7:36 Puyou Lu [this message]
2022-05-06 8:12 ` Andy Shevchenko
2022-05-07 18:45 ` Andrew Morton
2022-05-08 10:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220506073623.2679-1-puyou.lu@gmail.com \
--to=puyou.lu@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=chris@chrisdown.name \
--cc=keescook@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®