mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mickaël Salaün" <mic@digikod.net>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: "Mickaël Salaün" <mic@digikod.net>,
	"Andy Whitcroft" <apw@canonical.com>,
	"Brian Norris" <briannorris@chromium.org>,
	"Dwaipayan Ray" <dwaipayanray1@gmail.com>,
	"Jason A . Donenfeld" <Jason@zx2c4.com>,
	"Joe Perches" <joe@perches.com>,
	"Kees Cook" <keescook@chromium.org>,
	"Konstantin Meskhidze" <konstantin.meskhidze@huawei.com>,
	"Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Paul Moore" <paul@paul-moore.com>, "Tom Rix" <trix@redhat.com>,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: [PATCH v2 5/5] clang-format: Fix space after for_each macros
Date: Fri,  6 May 2022 18:01:06 +0200	[thread overview]
Message-ID: <20220506160106.522341-6-mic@digikod.net> (raw)
In-Reply-To: <20220506160106.522341-1-mic@digikod.net>

Set SpaceBeforeParens to ControlStatementsExceptForEachMacros to not add
space between a for_each macro and the following parenthesis.  This
option is available since clang-format-11 [1] and is in line with the
checkpatch.pl rules [2].

I found that this patch has also been sent by Brian Norris some weeks
ago [3].

Link: https://clang.llvm.org/docs/ClangFormatStyleOptions.html [1]
Link: https://lore.kernel.org/r/8b6b252b-47a6-9d52-f0bd-10d3bc4ad244@digikod.net [2]
Link: https://lore.kernel.org/lkml/YmHuZjmP9MxkgJ0R@google.com/ [3]
Cc: Miguel Ojeda <ojeda@kernel.org>
Cc: Tom Rix <trix@redhat.com>
Co-developed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Mickaël Salaün <mic@digikod.net>
Link: https://lore.kernel.org/r/20220506160106.522341-6-mic@digikod.net
---
 .clang-format | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.clang-format b/.clang-format
index 235f7bb8f84a..1e083df1a689 100644
--- a/.clang-format
+++ b/.clang-format
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 #
-# clang-format configuration file. Intended for clang-format >= 6.
+# clang-format configuration file. Intended for clang-format >= 11.
 #
 # For more information, see:
 #
@@ -667,7 +667,7 @@ SpaceAfterTemplateKeyword: true
 SpaceBeforeAssignmentOperators: true
 SpaceBeforeCtorInitializerColon: true
 SpaceBeforeInheritanceColon: true
-SpaceBeforeParens: ControlStatements
+SpaceBeforeParens: ControlStatementsExceptForEachMacros
 SpaceBeforeRangeBasedForLoopColon: true
 SpaceInEmptyParentheses: false
 SpacesBeforeTrailingComments: 1
-- 
2.35.1


  parent reply	other threads:[~2022-05-06 16:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06 16:01 [PATCH v2 0/5] Fix clang-format configuration according to checkpatch.pl Mickaël Salaün
2022-05-06 16:01 ` [PATCH v2 1/5] clang-format: Update and extend the for_each list with tools/ Mickaël Salaün
2022-05-20 11:57   ` Miguel Ojeda
2022-05-06 16:01 ` [PATCH v2 2/5] clang-format: Update to clang-format >= 6 Mickaël Salaün
2022-05-06 16:01 ` [PATCH v2 3/5] clang-format: Fix goto labels indentation Mickaël Salaün
2022-05-20 17:07   ` Miguel Ojeda
2022-05-06 16:01 ` [PATCH v2 4/5] clang-format: Fix empty curly braces Mickaël Salaün
2022-05-20 17:15   ` Miguel Ojeda
2022-05-20 17:24     ` Joe Perches
2022-05-20 17:50       ` Miguel Ojeda
2022-05-20 18:00         ` Joe Perches
2022-05-20 18:57           ` Miguel Ojeda
2022-05-23 11:14     ` Mickaël Salaün
2022-05-06 16:01 ` Mickaël Salaün [this message]
2022-05-11 15:40   ` [PATCH v2 5/5] clang-format: Fix space after for_each macros Joe Perches
2022-05-11 17:34     ` Mickaël Salaün
2022-05-11 17:38       ` Joe Perches
2022-05-11 14:19 ` [PATCH v2 0/5] Fix clang-format configuration according to checkpatch.pl Mickaël Salaün
2022-05-11 15:29   ` Miguel Ojeda
2022-05-11 17:38     ` Brian Norris
2022-05-11 17:40     ` Mickaël Salaün
2022-05-20 19:11 ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220506160106.522341-6-mic@digikod.net \
    --to=mic@digikod.net \
    --cc=Jason@zx2c4.com \
    --cc=apw@canonical.com \
    --cc=briannorris@chromium.org \
    --cc=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=konstantin.meskhidze@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=lukas.bulwahn@gmail.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=ojeda@kernel.org \
    --cc=paul@paul-moore.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®