From: Mario Limonciello <mario.limonciello@amd.com>
To: <mario.limonciello@amd.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
"open list:WATCHDOG DEVICE DRIVERS"
<linux-watchdog@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: <ionut_n2001@yahoo.com>
Subject: [PATCH] Watchdog: sp5100_tco: Lower verbosity of disabled watchdog hardware
Date: Mon, 9 May 2022 11:33:04 -0500 [thread overview]
Message-ID: <20220509163304.86-1-mario.limonciello@amd.com> (raw)
If watchdog hardware has been disabled, currently the kernel driver
will show at err level during probe:
"Watchdog hardware is disabled"
This is unnecessarily verbose as there is already a -ENODEV returned.
Lower the level to debug.
Reported-by: ionut_n2001@yahoo.com
Link: https://bugzilla.kernel.org/show_bug.cgi?id=215762
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/watchdog/sp5100_tco.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/sp5100_tco.c b/drivers/watchdog/sp5100_tco.c
index 86ffb58fbc85..e51ecbd5c8b7 100644
--- a/drivers/watchdog/sp5100_tco.c
+++ b/drivers/watchdog/sp5100_tco.c
@@ -286,7 +286,7 @@ static int sp5100_tco_timer_init(struct sp5100_tco *tco)
val = readl(SP5100_WDT_CONTROL(tco->tcobase));
if (val & SP5100_WDT_DISABLED) {
- dev_err(dev, "Watchdog hardware is disabled\n");
+ dev_dbg(dev, "Watchdog hardware is disabled\n");
return -ENODEV;
}
--
2.34.1
next reply other threads:[~2022-05-09 16:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 16:33 Mario Limonciello [this message]
2022-05-09 22:55 ` Guenter Roeck
2022-05-09 23:10 ` Limonciello, Mario
2022-05-09 23:15 ` Guenter Roeck
2022-05-10 0:33 ` Jerry Hoemann
2022-05-10 0:37 ` Mario Limonciello
2022-05-10 1:15 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220509163304.86-1-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=ionut_n2001@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®