mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Devid Antonio Filoni <devid.filoni@egluetechnologies.com>
To: Robin van der Gracht <robin@protonic.nl>,
	Oleksij Rempel <o.rempel@pengutronix.de>
Cc: kernel@pengutronix.de, linux-can@vger.kernel.org,
	Oleksij Rempel <linux@rempel-privat.de>,
	Oliver Hartkopp <socketcan@hartkopp.net>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Maxime Jayat <maxime.jayat@mobile-devices.fr>,
	kbuild test robot <lkp@intel.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Devid Antonio Filoni <devid.filoni@egluetechnologies.com>
Subject: [PATCH RESEND 0/2] j1939: make sure that sent DAT/CTL frames are marked as TX
Date: Mon,  9 May 2022 19:07:44 +0200	[thread overview]
Message-ID: <20220509170746.29893-1-devid.filoni@egluetechnologies.com> (raw)

Hello,

If candump -x is used to dump CAN bus traffic on an interface while a J1939
socket is sending multi-packet messages, then the DAT and CTL frames
show up as RX instead of TX.

This patch series sets to generated struct sk_buff the owning struct sock
pointer so that the MSG_DONTROUTE flag can be set by recv functions.

I'm not sure that j1939_session_skb_get is needed, I think that session->sk
could be directly passed as can_skb_set_owner parameter. This patch
is based on j1939_simple_txnext function which uses j1939_session_skb_get.
I can provide an additional patch to remove the calls to
j1939_session_skb_get function if you think they are not needed.

Thank you,
Devid

Devid Antonio Filoni (2):
  can: j1939: make sure that sent DAT frames are marked as TX
  can: j1939: make sure that sent CTL frames are marked as TX

 net/can/j1939/transport.c | 69 ++++++++++++++++++++++++++++++++-------
 1 file changed, 57 insertions(+), 12 deletions(-)

-- 
2.25.1


             reply	other threads:[~2022-05-09 17:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 17:07 Devid Antonio Filoni [this message]
2022-05-09 17:07 ` [PATCH RESEND 1/2] can: j1939: make sure that sent DAT " Devid Antonio Filoni
2022-05-09 17:07 ` [PATCH RESEND 2/2] can: j1939: make sure that sent CTL " Devid Antonio Filoni
2022-05-10  4:34 ` [PATCH RESEND 0/2] j1939: make sure that sent DAT/CTL " Oleksij Rempel
2022-05-10 18:12   ` Devid Antonio Filoni
2022-05-11 11:48     ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220509170746.29893-1-devid.filoni@egluetechnologies.com \
    --to=devid.filoni@egluetechnologies.com \
    --cc=davem@davemloft.net \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rempel-privat.de \
    --cc=lkp@intel.com \
    --cc=maxime.jayat@mobile-devices.fr \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=robin@protonic.nl \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®