From: Guenter Roeck <linux@roeck-us.net>
To: Karl Mehltretter <kmehltretter@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (lm83) Remove unused include directives
Date: Mon, 9 May 2022 17:29:45 -0700 [thread overview]
Message-ID: <20220510002945.GA1561373@roeck-us.net> (raw)
In-Reply-To: <20220508144601.22796-1-kmehltretter@gmail.com>
On Sun, May 08, 2022 at 04:46:01PM +0200, Karl Mehltretter wrote:
> Some include directives are no longer necessary due to previous driver
> changes. Remove them now to further improve driver code clarity.
>
> Mutex usage has ceased since commit 719af4f1a40b ("hwmon: (lm83) Use
> regmap").
>
> Ever since commit a0ac840d99fa ("hwmon: (lm83) Convert to use
> devm_hwmon_device_register_with_groups") functions sysfs_create_group
> and sysfs_remove_group are no longer used by the driver.
>
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Applied. Thanks!
Guenter
> ---
> drivers/hwmon/lm83.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hwmon/lm83.c b/drivers/hwmon/lm83.c
> index 12370dcef..905f5689f 100644
> --- a/drivers/hwmon/lm83.c
> +++ b/drivers/hwmon/lm83.c
> @@ -24,10 +24,8 @@
> #include <linux/init.h>
> #include <linux/hwmon.h>
> #include <linux/module.h>
> -#include <linux/mutex.h>
> #include <linux/regmap.h>
> #include <linux/slab.h>
> -#include <linux/sysfs.h>
>
> /*
> * Addresses to scan
prev parent reply other threads:[~2022-05-10 0:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-08 14:46 Karl Mehltretter
2022-05-10 0:29 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510002945.GA1561373@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=kmehltretter@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®