mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Zhang <starzhangzsd@gmail.com>
To: linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com,
	broonie@kernel.org, arnd@arndb.de, lukas.bulwahn@gmail.com,
	daniel@zonque.org
Cc: zhangshida@kylinos.cn, starzhangzsd@gmail.com,
	linux-kernel@vger.kernel.org, k2ci <kernel-bot@kylinos.cn>
Subject: [PATCH v3] pcmcia: add MIPS_DB1XXX dependence
Date: Tue, 10 May 2022 10:32:55 +0800	[thread overview]
Message-ID: <20220510023255.1283529-1-starzhangzsd@gmail.com> (raw)

From: Shida Zhang <zhangshida@kylinos.cn>

drivers/pcmcia/db1xxx_ss.c uses the bcsr_xxxx() from
arch/mips/alchemy/devboards/bcsr.c, which causes a link
error:

drivers/pcmcia/db1xxx_ss.c:(.text+0x2b4): undefined reference to `bcsr_read'
mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x2fc): undefined reference to `bcsr_read'
drivers/pcmcia/db1xxx_ss.c:(.text+0x374): undefined reference to `bcsr_read'
mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x380): undefined reference to `bcsr_read'
drivers/pcmcia/db1xxx_ss.c:(.text+0x534): undefined reference to `bcsr_read'
drivers/pcmcia/db1xxx_ss.c:(.text+0xcc8): undefined reference to `bcsr_mod'


So add MIPS_DB1XXX dependence.

Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: Shida Zhang <zhangshida@kylinos.cn>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
Changes from v1:
- Rewrite the commit message.
Changes from v2:
- Give credit to k2ci for reporting the issue.
---
 drivers/pcmcia/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig
index 2ce261cfff8e..04b51cb67fbf 100644
--- a/drivers/pcmcia/Kconfig
+++ b/drivers/pcmcia/Kconfig
@@ -151,7 +151,7 @@ config TCIC
 
 config PCMCIA_ALCHEMY_DEVBOARD
 	tristate "Alchemy Db/Pb1xxx PCMCIA socket services"
-	depends on MIPS_ALCHEMY && PCMCIA
+	depends on MIPS_ALCHEMY && MIPS_DB1XXX && PCMCIA
 	help
 	  Enable this driver of you want PCMCIA support on your Alchemy
 	  Db1000, Db/Pb1100, Db/Pb1500, Db/Pb1550, Db/Pb1200, DB1300
-- 
2.30.2


             reply	other threads:[~2022-05-10  2:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10  2:32 Stephen Zhang [this message]
2022-06-02  6:23 ` Stephen Zhang
2022-06-02  7:09   ` Dominik Brodowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220510023255.1283529-1-starzhangzsd@gmail.com \
    --to=starzhangzsd@gmail.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=daniel@zonque.org \
    --cc=kernel-bot@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=lukas.bulwahn@gmail.com \
    --cc=zhangshida@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®