From: Christian Brauner <brauner@kernel.org>
To: Carlos Llamas <cmllamas@google.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Hridya Valsaraju" <hridya@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] binder: fix printk format for commands
Date: Tue, 10 May 2022 12:12:00 +0200 [thread overview]
Message-ID: <20220510101200.kjbe4ibvscxaquoj@wittgenstein> (raw)
In-Reply-To: <20220509231901.3852573-1-cmllamas@google.com>
On Mon, May 09, 2022 at 11:19:01PM +0000, Carlos Llamas wrote:
> Make sure we use unsigned format specifier %u for binder commands as
> most of them are encoded above INT_MAX. This prevents negative values
> when logging them as in the following case:
>
> [ 211.895781] binder: 8668:8668 BR_REPLY 258949 0:0, cmd -2143260157 size 0-0 ptr 0000006e766a8000-0000006e766a8000
>
> Signed-off-by: Carlos Llamas <cmllamas@google.com>
> ---
Looks good to me,
Acked-by: Christian Brauner (Microsoft) <brauner@kernel.org>
prev parent reply other threads:[~2022-05-10 10:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 23:19 Carlos Llamas
2022-05-09 23:24 ` Todd Kjos
2022-05-10 10:12 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510101200.kjbe4ibvscxaquoj@wittgenstein \
--to=brauner@kernel.org \
--cc=arve@android.com \
--cc=cmllamas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®