mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Michael Walle <michael@walle.cc>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org, Pratyush Yadav <p.yadav@ti.com>
Subject: [mtd:spi-nor/next 16/18] drivers/mtd/spi-nor/debugfs.c:84 spi_nor_params_show() warn: '%ph' cannot be followed by 'n'
Date: Wed, 11 May 2022 13:17:51 +0300	[thread overview]
Message-ID: <202205110320.WNi7ZQaB-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next
head:   cdbc44dbb2c73d8bafa1a8ae0d780608be5dbd40
commit: 0257be79fc4a16a3252ce80aa13b3640f728c425 [16/18] mtd: spi-nor: expose internal parameters via debugfs
config: x86_64-randconfig-m001-20220509 (https://download.01.org/0day-ci/archive/20220511/202205110320.WNi7ZQaB-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/mtd/spi-nor/debugfs.c:84 spi_nor_params_show() warn: '%ph' cannot be followed by 'n'

vim +84 drivers/mtd/spi-nor/debugfs.c

0257be79fc4a16 Michael Walle 2022-04-29   73  static int spi_nor_params_show(struct seq_file *s, void *data)
0257be79fc4a16 Michael Walle 2022-04-29   74  {
0257be79fc4a16 Michael Walle 2022-04-29   75  	struct spi_nor *nor = s->private;
0257be79fc4a16 Michael Walle 2022-04-29   76  	struct spi_nor_flash_parameter *params = nor->params;
0257be79fc4a16 Michael Walle 2022-04-29   77  	struct spi_nor_erase_map *erase_map = &params->erase_map;
0257be79fc4a16 Michael Walle 2022-04-29   78  	struct spi_nor_erase_region *region;
0257be79fc4a16 Michael Walle 2022-04-29   79  	const struct flash_info *info = nor->info;
0257be79fc4a16 Michael Walle 2022-04-29   80  	char buf[16], *str;
0257be79fc4a16 Michael Walle 2022-04-29   81  	int i;
0257be79fc4a16 Michael Walle 2022-04-29   82  
0257be79fc4a16 Michael Walle 2022-04-29   83  	seq_printf(s, "name\t\t%s\n", info->name);
0257be79fc4a16 Michael Walle 2022-04-29  @84  	seq_printf(s, "id\t\t%*phn\n", info->id_len, info->id);

Maybe N was intended instead of n?  (I have no idea).

0257be79fc4a16 Michael Walle 2022-04-29   85  	string_get_size(params->size, 1, STRING_UNITS_2, buf, sizeof(buf));
0257be79fc4a16 Michael Walle 2022-04-29   86  	seq_printf(s, "size\t\t%s\n", buf);
0257be79fc4a16 Michael Walle 2022-04-29   87  	seq_printf(s, "write size\t%u\n", params->writesize);
0257be79fc4a16 Michael Walle 2022-04-29   88  	seq_printf(s, "page size\t%u\n", params->page_size);
0257be79fc4a16 Michael Walle 2022-04-29   89  	seq_printf(s, "address width\t%u\n", nor->addr_width);
0257be79fc4a16 Michael Walle 2022-04-29   90  
0257be79fc4a16 Michael Walle 2022-04-29   91  	seq_puts(s, "flags\t\t");

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp


             reply	other threads:[~2022-05-11 10:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11 10:17 Dan Carpenter [this message]
2022-05-11 11:35 ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202205110320.WNi7ZQaB-lkp@intel.com \
    --to=dan.carpenter@oracle.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=michael@walle.cc \
    --cc=p.yadav@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome