From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80A14C433FE for ; Thu, 12 May 2022 06:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350170AbiELGNQ (ORCPT ); Thu, 12 May 2022 02:13:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349200AbiELGNN (ORCPT ); Thu, 12 May 2022 02:13:13 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A0D571D91 for ; Wed, 11 May 2022 23:13:12 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-2f7ee6bc6ddso37716157b3.1 for ; Wed, 11 May 2022 23:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=k2mrwNMnDRDtKU4GgM7wzGIZDxmWj/S0FET83F74pgg=; b=Pn5/YRZEdz4bLQyrZFlg+WTrDF1ez3jNuU3oeeYtBPOfI5LbGlFTaJfwufzjmSUY0V hsMopSSrrhIMQ9tMydE/FdeV78QAtkeahrMuNxv53QreiyxNamrOK/BuL3+EhnIqBi/Z F8fcCVwiJPR8TYY4LThQSjVlQ0z4/qoNCP8V38dKAikPu2Ol3b8SFyRtFfUvwvw4GSKk 3CAYqZjRDIx8pGR0ADieFNK9hHZfOVmewF65P1wtD+mGuAtlGQbUF/KqagrGCye0E3kS d7o2Twa7snYiyV9H4hMQGrbEgrolqc2F/i9MH466tgVdYt9/47HhLs+MJhSx6Ivx6+EW GeZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=k2mrwNMnDRDtKU4GgM7wzGIZDxmWj/S0FET83F74pgg=; b=GHWOHTCb5teb6gVs3slo1YAKfDba1gmyzCNwGmGsecnnkBfzb4iUkCA10A7Lf7tVy5 bbI1YLEo68RxCXoUeenSyGqoNWXW+4n3itqG8u7K/LHtYH7UhMcf04Pgow6r/KGfEjdA ZyWnGQp2A6zK3zoqYVoTp8M3fB5fpJPKj8aR4XHmKYmAQWWWj11Uuga2OliqoJz6UGgt tRcS941APHCjHmr5qOG+3p8TdFtorrgdWnlThuYV+0lENVUFVd3n+rtkqD7K0UXhiQ0/ B0YYelm7xe1jXj0E3lt/No4Gp+8gW6R8f20Yp1RcRJQkd8wvI1dYCRv2oHJDQOZ0bBOn IA9g== X-Gm-Message-State: AOAM531F5kg5Mv8TlI5QxP6g9dYwrQHGmshf45aSNgrx6qQLc2Q4fkEd /IroGwX/nK66P8QnIwF75hPPL3BKBVIo X-Google-Smtp-Source: ABdhPJwbvviNfoKin2ClLu67Q4c9Lr6aurmjWUX+jvvCQpLwrsh4JwVF6ENzbLc6q1jbFTQcQUbiXHqgYecC X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:5993:294b:7b62:54cb]) (user=irogers job=sendgmr) by 2002:a25:c1c3:0:b0:648:e9af:111f with SMTP id r186-20020a25c1c3000000b00648e9af111fmr29222012ybf.168.1652335991609; Wed, 11 May 2022 23:13:11 -0700 (PDT) Date: Wed, 11 May 2022 23:13:06 -0700 Message-Id: <20220512061308.1152233-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.36.0.512.ge40c2bad7a-goog Subject: [PATCH v2 0/2] Fix topdown event weak grouping From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Riccardo Mancini , Kim Phillips , Madhavan Srinivasan , Shunsuke Nakamura , Florian Fischer , Andi Kleen , John Garry , Zhengjun Xing , Adrian Hunter , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stephane Eranian , Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Keep topdown events within a group when a weak group is broken. This is a requirement as topdown events must form a group. Add perf stat testing including for required topdown event group behaviors. Note: as with existing topdown evsel/evlist code topdown events are assumed to be on the PMU "cpu". On Alderlake the PMU "cpu_core" should also be tested. Future changes can fix Alderlake. v2. Correct behavior wrt pmu prefixed events and avoid the test using deprecated events: Suggested-by: Liang, Kan Ian Rogers (2): perf evlist: Keep topdown counters in weak group perf test: Add basic stat and topdown group test tools/perf/arch/x86/util/evsel.c | 12 ++++++ tools/perf/tests/shell/stat.sh | 67 ++++++++++++++++++++++++++++++++ tools/perf/util/evlist.c | 16 +++++++- tools/perf/util/evsel.c | 10 +++++ tools/perf/util/evsel.h | 3 ++ 5 files changed, 106 insertions(+), 2 deletions(-) create mode 100755 tools/perf/tests/shell/stat.sh -- 2.36.0.512.ge40c2bad7a-goog